2021-01-23 17:36:17

by Esmil

Subject: [PATCH 0/2] net: usbnet: convert to new tasklet API

From: Emil Renner Berthing <[email protected]>

This converts the usbnet driver to use the new tasklet API introduced in
commit 12cc923f1ccc ("tasklet: Introduce new initialization API")

It is split into two commits for ease of reviewing.

Emil Renner Berthing (2):
net: usbnet: use tasklet_init
net: usbnet: use new tasklet API

drivers/net/usb/usbnet.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

--
2.30.0

2021-01-23 17:37:47

by Esmil

Subject: [PATCH 1/2] net: usbnet: initialize tasklet using tasklet_init

From: Emil Renner Berthing <[email protected]>

Initialize tasklet using tasklet_init() rather than open-coding it.

Signed-off-by: Emil Renner Berthing <[email protected]>
---
drivers/net/usb/usbnet.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 1447da1d5729..26455c76588f 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1673,8 +1673,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
skb_queue_head_init (&dev->txq);
skb_queue_head_init (&dev->done);
skb_queue_head_init(&dev->rxq_pause);
- dev->bh.func = usbnet_bh_tasklet;
- dev->bh.data = (unsigned long)&dev->delay;
+ tasklet_init(&dev->bh, usbnet_bh_tasklet, (unsigned long)&dev->delay);
INIT_WORK (&dev->kevent, usbnet_deferred_kevent);
init_usb_anchor(&dev->deferred);
timer_setup(&dev->delay, usbnet_bh, 0);
--
2.30.0

2021-01-27 21:18:27

by patchwork-bot+netdevbpf

Subject: Re: [PATCH 0/2] net: usbnet: convert to new tasklet API

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Sat, 23 Jan 2021 18:32:19 +0100 you wrote:
> From: Emil Renner Berthing <[email protected]>
>
> This converts the usbnet driver to use the new tasklet API introduced in
> commit 12cc923f1ccc ("tasklet: Introduce new initialization API")
>
> It is split into two commits for ease of reviewing.
>
> [...]

Here is the summary with links:
- [1/2] net: usbnet: initialize tasklet using tasklet_init
https://git.kernel.org/netdev/net-next/c/90a586b8d741
- [2/2] net: usbnet: use new tasklet API
https://git.kernel.org/netdev/net-next/c/c955e329bb9d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2021-02-01 10:38:16

by Oliver Neukum

Subject: Re: [PATCH 1/2] net: usbnet: initialize tasklet using tasklet_init

Am Samstag, den 23.01.2021, 18:32 +0100 schrieb Emil Renner Berthing:
> From: Emil Renner Berthing <[email protected]>
>
> Initialize tasklet using tasklet_init() rather than open-coding it.
>
> Signed-off-by: Emil Renner Berthing <[email protected]>
Acked-by: Oliver Neukum <[email protected]>