2017-09-14 21:15:41

by Jiri Kosina

Subject: [PATCH] livepatch: __klp_shadow_get_or_alloc() is local to shadow.c

From: Jiri Kosina <[email protected]>

... therefore make it static.

Fixes: 439e7271dc2 ("livepatch: introduce shadow variable API")
Signed-off-by: Jiri Kosina <[email protected]>
---

Sorry for not having spotted this before pushing out.

kernel/livepatch/shadow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/livepatch/shadow.c b/kernel/livepatch/shadow.c
index 67e4360..fdac275 100644
--- a/kernel/livepatch/shadow.c
+++ b/kernel/livepatch/shadow.c
@@ -113,7 +113,7 @@ void *klp_shadow_get(void *obj, unsigned long id)
}
EXPORT_SYMBOL_GPL(klp_shadow_get);

-void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
+static void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
size_t size, gfp_t gfp_flags, bool warn_on_exist)
{
struct klp_shadow *new_shadow;
--
1.8.5.6

2017-09-15 14:28:55

by Joe Lawrence

Subject: Re: [PATCH] livepatch: __klp_shadow_get_or_alloc() is local to shadow.c

On Thu, Sep 14, 2017 at 02:15:36PM -0700, Jiri Kosina wrote:
> From: Jiri Kosina <[email protected]>
>
> ... therefore make it static.
>
> Fixes: 439e7271dc2 ("livepatch: introduce shadow variable API")
> Signed-off-by: Jiri Kosina <[email protected]>
> ---
>
> Sorry for not having spotted this before pushing out.
>
> kernel/livepatch/shadow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/livepatch/shadow.c b/kernel/livepatch/shadow.c
> index 67e4360..fdac275 100644
> --- a/kernel/livepatch/shadow.c
> +++ b/kernel/livepatch/shadow.c
> @@ -113,7 +113,7 @@ void *klp_shadow_get(void *obj, unsigned long id)
> }
> EXPORT_SYMBOL_GPL(klp_shadow_get);
>
> -void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> +static void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> size_t size, gfp_t gfp_flags, bool warn_on_exist)
> {
> struct klp_shadow *new_shadow;
> --
> 1.8.5.6

Acked-by: Joe Lawrence <[email protected]>

Thanks for cleaning this up, Jiri.

Also thanks to Miroslav, Petr, Nicolai and Josh for the patchset
reviews!

-- Joe

2017-09-19 11:48:53

by Miroslav Benes

Subject: Re: [PATCH] livepatch: __klp_shadow_get_or_alloc() is local to shadow.c

On Thu, 14 Sep 2017, Jiri Kosina wrote:

> From: Jiri Kosina <[email protected]>
>
> ... therefore make it static.
>
> Fixes: 439e7271dc2 ("livepatch: introduce shadow variable API")
> Signed-off-by: Jiri Kosina <[email protected]>
> ---

FWIW (but I noticed you've already applied it)

Acked-by: Miroslav Benes <[email protected]>

Miroslav