2021-06-01 11:23:02

by Jiapeng Chong

Subject: [PATCH] HID: usbhid: hid-pidff: Fix missing error code in hid_pidff_init()

The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'error'.

Eliminate the follow smatch warning:

drivers/hid/usbhid/hid-pidff.c:1297 hid_pidff_init() warn: missing error
code 'error'.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/hid/usbhid/hid-pidff.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
index ea126c5..731b49e 100644
--- a/drivers/hid/usbhid/hid-pidff.c
+++ b/drivers/hid/usbhid/hid-pidff.c
@@ -1294,6 +1294,7 @@ int hid_pidff_init(struct hid_device *hid)
pidff->pool[PID_DEVICE_MANAGED_POOL].value[0] == 0) {
hid_notice(hid,
"device does not support device managed pool\n");
+ error = -EINVAL;
goto fail;
}

--
1.8.3.1

2021-06-24 12:07:22

by Jiri Kosina

Subject: Re: [PATCH] HID: usbhid: hid-pidff: Fix missing error code in hid_pidff_init()

On Tue, 1 Jun 2021, Jiapeng Chong wrote:

> The error code is missing in this code scenario, add the error code
> '-EINVAL' to the return value 'error'.
>
> Eliminate the follow smatch warning:
>
> drivers/hid/usbhid/hid-pidff.c:1297 hid_pidff_init() warn: missing error
> code 'error'.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

This has already been fixed in hid.git via 3dd653c077efd.

Thanks,

--
Jiri Kosina
SUSE Labs