2021-07-04 22:28:29

by Luke D. Jones

Subject: [PATCH] HID: asus: Remove check for same LED brightness on set

Remove the early return on LED brightness set so that any controller
application, daemon, or desktop may set the same brightness at any stage.

This is required because many ASUS ROG keyboards will default to max
brightness on laptop resume if the LEDs were set to off before sleep.

Signed-off-by: Luke D Jones <[email protected]>
---
drivers/hid/hid-asus.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 60606c11bdaf..19da81d2a910 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -486,9 +486,6 @@ static void asus_kbd_backlight_set(struct led_classdev *led_cdev,
{
struct asus_kbd_leds *led = container_of(led_cdev, struct asus_kbd_leds,
cdev);
- if (led->brightness == brightness)
- return;
-
led->brightness = brightness;
schedule_work(&led->work);
}
--
2.31.1

2021-07-15 21:09:56

by Jiri Kosina

Subject: Re: [PATCH] HID: asus: Remove check for same LED brightness on set

On Mon, 5 Jul 2021, Luke D. Jones wrote:

> Remove the early return on LED brightness set so that any controller
> application, daemon, or desktop may set the same brightness at any stage.
>
> This is required because many ASUS ROG keyboards will default to max
> brightness on laptop resume if the LEDs were set to off before sleep.
>
> Signed-off-by: Luke D Jones <[email protected]>

Applied, thanks.

--
Jiri Kosina
SUSE Labs