2022-01-07 23:23:10

by Stephen Boyd

Subject: [PATCH] HID: vivaldi: Minor cleanups

Perform some minor cleanups on this driver. Include header files for
struct definitions that are used, drop a forward declaration that isn't
useful, and mark a sysfs attribute static as it isn't used outside this
file.

Cc: Sean O'Brien <[email protected]>
Cc: Ting Shen <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/hid/hid-vivaldi.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/hid-vivaldi.c b/drivers/hid/hid-vivaldi.c
index cd7ada48b1d9..90ebb33380b7 100644
--- a/drivers/hid/hid-vivaldi.c
+++ b/drivers/hid/hid-vivaldi.c
@@ -6,16 +6,17 @@
* Author: Sean O'Brien <[email protected]>
*/

+#include <linux/device.h>
#include <linux/hid.h>
+#include <linux/kernel.h>
#include <linux/module.h>
+#include <linux/sysfs.h>

#define MIN_FN_ROW_KEY 1
#define MAX_FN_ROW_KEY 24
#define HID_VD_FN_ROW_PHYSMAP 0x00000001
#define HID_USAGE_FN_ROW_PHYSMAP (HID_UP_GOOGLEVENDOR | HID_VD_FN_ROW_PHYSMAP)

-static struct hid_driver hid_vivaldi;
-
struct vivaldi_data {
u32 function_row_physmap[MAX_FN_ROW_KEY - MIN_FN_ROW_KEY + 1];
int max_function_row_key;
@@ -40,7 +41,7 @@ static ssize_t function_row_physmap_show(struct device *dev,
return size;
}

-DEVICE_ATTR_RO(function_row_physmap);
+static DEVICE_ATTR_RO(function_row_physmap);
static struct attribute *sysfs_attrs[] = {
&dev_attr_function_row_physmap.attr,
NULL

base-commit: 136057256686de39cc3a07c2e39ef6bc43003ff6
--
https://chromeos.dev

2022-01-14 10:52:44

by Jiri Kosina

Subject: Re: [PATCH] HID: vivaldi: Minor cleanups

On Fri, 7 Jan 2022, Stephen Boyd wrote:

> Perform some minor cleanups on this driver. Include header files for
> struct definitions that are used, drop a forward declaration that isn't
> useful, and mark a sysfs attribute static as it isn't used outside this
> file.
>
> Cc: Sean O'Brien <[email protected]>
> Cc: Ting Shen <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>

Applied to hid.git#for-5.17/upstream-fixes

--
Jiri Kosina
SUSE Labs