Hi Daniel,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b81b1829e7e39f6cebdf6e4d5484eacbceda8554
commit: dad74e18f72a852ae40ad7b4246841a1b7e196b5 HID: nintendo: prevent needless queueing of the rumble worker
date: 4 months ago
config: parisc-randconfig-r024-20220213 (https://download.01.org/0day-ci/archive/20220214/[email protected]/config)
compiler: hppa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dad74e18f72a852ae40ad7b4246841a1b7e196b5
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout dad74e18f72a852ae40ad7b4246841a1b7e196b5
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash drivers/hid/ fs/notify/fanotify/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
>> drivers/hid/hid-nintendo.c:403:29: error: 'JC_RUMBLE_ZERO_AMP_PKT_CNT' defined but not used [-Werror=unused-const-variable=]
403 | static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT = 5;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:401:18: error: 'JC_RUMBLE_DFLT_HIGH_FREQ' defined but not used [-Werror=unused-const-variable=]
401 | static const u16 JC_RUMBLE_DFLT_HIGH_FREQ = 320;
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:400:18: error: 'JC_RUMBLE_DFLT_LOW_FREQ' defined but not used [-Werror=unused-const-variable=]
400 | static const u16 JC_RUMBLE_DFLT_LOW_FREQ = 160;
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:254:44: error: 'joycon_rumble_amplitudes' defined but not used [-Werror=unused-const-variable=]
254 | static const struct joycon_rumble_amp_data joycon_rumble_amplitudes[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:196:45: error: 'joycon_rumble_frequencies' defined but not used [-Werror=unused-const-variable=]
196 | static const struct joycon_rumble_freq_data joycon_rumble_frequencies[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:99:17: error: 'JC_USB_SEND_UART' defined but not used [-Werror=unused-const-variable=]
99 | static const u8 JC_USB_SEND_UART = 0x92;
| ^~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:98:17: error: 'JC_USB_PRE_HANDSHAKE' defined but not used [-Werror=unused-const-variable=]
98 | static const u8 JC_USB_PRE_HANDSHAKE = 0x91;
| ^~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:97:17: error: 'JC_USB_RESET' defined but not used [-Werror=unused-const-variable=]
97 | static const u8 JC_USB_RESET = 0x06;
| ^~~~~~~~~~~~
drivers/hid/hid-nintendo.c:96:17: error: 'JC_USB_CMD_EN_TIMEOUT' defined but not used [-Werror=unused-const-variable=]
96 | static const u8 JC_USB_CMD_EN_TIMEOUT = 0x05;
| ^~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:92:17: error: 'JC_USB_CMD_CONN_STATUS' defined but not used [-Werror=unused-const-variable=]
92 | static const u8 JC_USB_CMD_CONN_STATUS = 0x01;
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:89:17: error: 'JC_FEATURE_LAUNCH' defined but not used [-Werror=unused-const-variable=]
89 | static const u8 JC_FEATURE_LAUNCH = 0x75;
| ^~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:88:17: error: 'JC_FEATURE_MEM_WRITE' defined but not used [-Werror=unused-const-variable=]
88 | static const u8 JC_FEATURE_MEM_WRITE = 0x74;
| ^~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:87:17: error: 'JC_FEATURE_ERASE_MEM_SECTOR' defined but not used [-Werror=unused-const-variable=]
87 | static const u8 JC_FEATURE_ERASE_MEM_SECTOR = 0x73;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:86:17: error: 'JC_FEATURE_MEM_READ' defined but not used [-Werror=unused-const-variable=]
86 | static const u8 JC_FEATURE_MEM_READ = 0x72;
| ^~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:85:17: error: 'JC_FEATURE_SETUP_MEM_READ' defined but not used [-Werror=unused-const-variable=]
85 | static const u8 JC_FEATURE_SETUP_MEM_READ = 0x71;
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:84:17: error: 'JC_FEATURE_OTA_FW_UPGRADE' defined but not used [-Werror=unused-const-variable=]
84 | static const u8 JC_FEATURE_OTA_FW_UPGRADE = 0x70;
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:83:17: error: 'JC_FEATURE_LAST_SUBCMD' defined but not used [-Werror=unused-const-variable=]
83 | static const u8 JC_FEATURE_LAST_SUBCMD = 0x02;
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:76:17: error: 'JC_INPUT_BUTTON_EVENT' defined but not used [-Werror=unused-const-variable=]
76 | static const u8 JC_INPUT_BUTTON_EVENT = 0x3F;
| ^~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:73:17: error: 'JC_SUBCMD_GET_REGULATED_VOLTAGE' defined but not used [-Werror=unused-const-variable=]
73 | static const u8 JC_SUBCMD_GET_REGULATED_VOLTAGE = 0x50;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:71:17: error: 'JC_SUBCMD_READ_IMU_REG' defined but not used [-Werror=unused-const-variable=]
71 | static const u8 JC_SUBCMD_READ_IMU_REG = 0x43;
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:70:17: error: 'JC_SUBCMD_WRITE_IMU_REG' defined but not used [-Werror=unused-const-variable=]
70 | static const u8 JC_SUBCMD_WRITE_IMU_REG = 0x42;
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:69:17: error: 'JC_SUBCMD_SET_IMU_SENSITIVITY' defined but not used [-Werror=unused-const-variable=]
69 | static const u8 JC_SUBCMD_SET_IMU_SENSITIVITY = 0x41;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:66:17: error: 'JC_SUBCMD_GET_PLAYER_LIGHTS' defined but not used [-Werror=unused-const-variable=]
66 | static const u8 JC_SUBCMD_GET_PLAYER_LIGHTS = 0x31;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:64:17: error: 'JC_SUBCMD_SET_MCU_STATE' defined but not used [-Werror=unused-const-variable=]
64 | static const u8 JC_SUBCMD_SET_MCU_STATE = 0x22;
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:63:17: error: 'JC_SUBCMD_SET_MCU_CONFIG' defined but not used [-Werror=unused-const-variable=]
63 | static const u8 JC_SUBCMD_SET_MCU_CONFIG = 0x21;
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:62:17: error: 'JC_SUBCMD_RESET_MCU' defined but not used [-Werror=unused-const-variable=]
62 | static const u8 JC_SUBCMD_RESET_MCU = 0x20;
| ^~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:61:17: error: 'JC_SUBCMD_SPI_FLASH_WRITE' defined but not used [-Werror=unused-const-variable=]
61 | static const u8 JC_SUBCMD_SPI_FLASH_WRITE = 0x11;
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:59:17: error: 'JC_SUBCMD_LOW_POWER_MODE' defined but not used [-Werror=unused-const-variable=]
59 | static const u8 JC_SUBCMD_LOW_POWER_MODE = 0x08;
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:58:17: error: 'JC_SUBCMD_RESET_PAIRING_INFO' defined but not used [-Werror=unused-const-variable=]
58 | static const u8 JC_SUBCMD_RESET_PAIRING_INFO = 0x07;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:57:17: error: 'JC_SUBCMD_SET_HCI_STATE' defined but not used [-Werror=unused-const-variable=]
57 | static const u8 JC_SUBCMD_SET_HCI_STATE = 0x06;
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:56:17: error: 'JC_SUBCMD_GET_PAGE_LIST_STATE' defined but not used [-Werror=unused-const-variable=]
56 | static const u8 JC_SUBCMD_GET_PAGE_LIST_STATE = 0x05;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:55:17: error: 'JC_SUBCMD_TRIGGERS_ELAPSED' defined but not used [-Werror=unused-const-variable=]
55 | static const u8 JC_SUBCMD_TRIGGERS_ELAPSED = 0x04;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:52:17: error: 'JC_SUBCMD_MANUAL_BT_PAIRING' defined but not used [-Werror=unused-const-variable=]
52 | static const u8 JC_SUBCMD_MANUAL_BT_PAIRING = 0x01;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/hid/hid-nintendo.c:51:17: error: 'JC_SUBCMD_STATE' defined but not used [-Werror=unused-const-variable=]
51 | static const u8 JC_SUBCMD_STATE /*= 0x00*/;
vim +/JC_RUMBLE_ZERO_AMP_PKT_CNT +403 drivers/hid/hid-nintendo.c
399
400 static const u16 JC_RUMBLE_DFLT_LOW_FREQ = 160;
401 static const u16 JC_RUMBLE_DFLT_HIGH_FREQ = 320;
402 static const u16 JC_RUMBLE_PERIOD_MS = 50;
> 403 static const unsigned short JC_RUMBLE_ZERO_AMP_PKT_CNT = 5;
404
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
On Mon, 14 Feb 2022, kernel test robot wrote:
> Hi Daniel,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: b81b1829e7e39f6cebdf6e4d5484eacbceda8554
> commit: dad74e18f72a852ae40ad7b4246841a1b7e196b5 HID: nintendo: prevent needless queueing of the rumble worker
> date: 4 months ago
> config: parisc-randconfig-r024-20220213 (https://download.01.org/0day-ci/archive/20220214/[email protected]/config)
> compiler: hppa-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dad74e18f72a852ae40ad7b4246841a1b7e196b5
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout dad74e18f72a852ae40ad7b4246841a1b7e196b5
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=parisc SHELL=/bin/bash drivers/hid/ fs/notify/fanotify/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
Daniel, I understand that the constants are there for future reference,
but could you please submit a patch that'd make them commented out for
now?
Thanks,
--
Jiri Kosina
SUSE Labs