2022-11-17 12:39:57

by Marcus Folkesson

Subject: [PATCH RESEND] HID: hid-alps: use default remove for hid device

hid_device_remove() will call hid_hw_stop() as default .remove function
if no function is specified.

Signed-off-by: Marcus Folkesson <[email protected]>
---
drivers/hid/hid-alps.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index 2b986d0dbde4..9abaff6f3afb 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -820,11 +820,6 @@ static int alps_probe(struct hid_device *hdev, const struct hid_device_id *id)
return 0;
}

-static void alps_remove(struct hid_device *hdev)
-{
- hid_hw_stop(hdev);
-}
-
static const struct hid_device_id alps_id[] = {
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },
@@ -840,7 +835,6 @@ static struct hid_driver alps_driver = {
.name = "hid-alps",
.id_table = alps_id,
.probe = alps_probe,
- .remove = alps_remove,
.raw_event = alps_raw_event,
.input_mapping = alps_input_mapping,
.input_configured = alps_input_configured,
--
2.38.1

2022-11-21 21:42:13

by Jiri Kosina

Subject: Re: [PATCH RESEND] HID: hid-alps: use default remove for hid device

On Thu, 17 Nov 2022, Marcus Folkesson wrote:

> hid_device_remove() will call hid_hw_stop() as default .remove function
> if no function is specified.
>
> Signed-off-by: Marcus Folkesson <[email protected]>
> ---
> drivers/hid/hid-alps.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
> index 2b986d0dbde4..9abaff6f3afb 100644
> --- a/drivers/hid/hid-alps.c
> +++ b/drivers/hid/hid-alps.c
> @@ -820,11 +820,6 @@ static int alps_probe(struct hid_device *hdev, const struct hid_device_id *id)
> return 0;
> }
>
> -static void alps_remove(struct hid_device *hdev)
> -{
> - hid_hw_stop(hdev);
> -}
> -
> static const struct hid_device_id alps_id[] = {
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
> USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },
> @@ -840,7 +835,6 @@ static struct hid_driver alps_driver = {
> .name = "hid-alps",
> .id_table = alps_id,
> .probe = alps_probe,
> - .remove = alps_remove,
> .raw_event = alps_raw_event,
> .input_mapping = alps_input_mapping,
> .input_configured = alps_input_configured,

Applied, thanks.

--
Jiri Kosina
SUSE Labs