2022-11-24 19:00:43

by José Expósito

[permalink] [raw]
Subject: [PATCH RESEND 0/1] HID: input: map battery system charging

Hi everyone,

This patch adds support for reporting battery status (charging/discharging)
for devices with a charging usage in their HID descriptor:

0x05, 0x85, /* Usage Page (Battery System), */
0x09, 0x44, /* Usage Page (Charging), */

I tested it on Apple hardware (mouse, trackpad and keyboard) as well as
on UCLogic tablets with battery [1].

On other hardware (HID_DC_BATTERYSTRENGTH or digitizers with battery)
discharging should be reported for backwards compatibility.
I did my best to keep the old behaviour by adding KUnit tests; However,
I don't own any of those devices, so I'd appreciate any help testing
the patch from someone with the actual hardware.

Best wishes,
José Expósito

[1] https://lore.kernel.org/linux-input/[email protected]/

José Expósito (1):
HID: input: map battery system charging

drivers/hid/.kunitconfig | 1 +
drivers/hid/Kconfig | 1 +
drivers/hid/hid-input-test.c | 80 ++++++++++++++++++++++++++++++++++++
drivers/hid/hid-input.c | 36 +++++++++++++++-
include/linux/hid.h | 2 +
5 files changed, 118 insertions(+), 2 deletions(-)
create mode 100644 drivers/hid/hid-input-test.c

--
2.38.1


2022-12-20 15:11:18

by Jiri Kosina

[permalink] [raw]
Subject: Re: [PATCH RESEND 0/1] HID: input: map battery system charging

On Thu, 24 Nov 2022, José Expósito wrote:

> Hi everyone,
>
> This patch adds support for reporting battery status (charging/discharging)
> for devices with a charging usage in their HID descriptor:
>
> 0x05, 0x85, /* Usage Page (Battery System), */
> 0x09, 0x44, /* Usage Page (Charging), */
>
> I tested it on Apple hardware (mouse, trackpad and keyboard) as well as
> on UCLogic tablets with battery [1].
>
> On other hardware (HID_DC_BATTERYSTRENGTH or digitizers with battery)
> discharging should be reported for backwards compatibility.
> I did my best to keep the old behaviour by adding KUnit tests; However,
> I don't own any of those devices, so I'd appreciate any help testing
> the patch from someone with the actual hardware.

I have applied this to hid.git#for-6.3/hid-core so that we get early
testing coverage in linux-next as soon as 6.2-rc1 is out.

Thanks,

--
Jiri Kosina
SUSE Labs