2022-11-28 17:28:00

by José Expósito

Subject: [PATCH] HID: sony: Fix unused function warning

Compiling this driver without setting "CONFIG_SONY_FF" generates the
following warning:

drivers/hid/hid-sony.c:2358:20: warning: unused function
'sony_send_output_report' [-Wunused-function]
static inline void sony_send_output_report(struct sony_sc *sc)
^
1 warning generated.

Add the missing preprocessor check to fix it.

Signed-off-by: José Expósito <[email protected]>
---
drivers/hid/hid-sony.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 03691cdcfb8e..13125997ab5e 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -2355,11 +2355,13 @@ static void motion_send_output_report(struct sony_sc *sc)
hid_hw_output_report(hdev, (u8 *)report, MOTION_REPORT_0x02_SIZE);
}

+#ifdef CONFIG_SONY_FF
static inline void sony_send_output_report(struct sony_sc *sc)
{
if (sc->send_output_report)
sc->send_output_report(sc);
}
+#endif

static void sony_state_worker(struct work_struct *work)
{
--
2.38.1

2022-12-20 14:52:43

by Jiri Kosina

Subject: Re: [PATCH] HID: sony: Fix unused function warning

On Mon, 28 Nov 2022, José Expósito wrote:

> Compiling this driver without setting "CONFIG_SONY_FF" generates the
> following warning:
>
> drivers/hid/hid-sony.c:2358:20: warning: unused function
> 'sony_send_output_report' [-Wunused-function]
> static inline void sony_send_output_report(struct sony_sc *sc)
> ^
> 1 warning generated.
>
> Add the missing preprocessor check to fix it.
>
> Signed-off-by: José Expósito <[email protected]>

Thanks for fixing this, now applied.

--
Jiri Kosina
SUSE Labs