2023-01-09 12:36:12

by qi feng

Subject: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID

From: fengqi <[email protected]>

Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
event is non-existent in current HID driver.
So we add this event in hid-input.c

Signed-off-by: fengqi <[email protected]>
---
drivers/hid/hid-input.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 9b59e436df0a..22cca3406b5c 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1105,6 +1105,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
case 0x0e5: map_key_clear(KEY_BASSBOOST); break;
case 0x0e9: map_key_clear(KEY_VOLUMEUP); break;
case 0x0ea: map_key_clear(KEY_VOLUMEDOWN); break;
+ case 0x0ee: map_key_clear(KEY_CAMERA_FOCUS); break;
case 0x0f5: map_key_clear(KEY_SLOW); break;

case 0x181: map_key_clear(KEY_BUTTONCONFIG); break;
--
2.39.0

2023-01-10 10:25:55

by qi feng

Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID

loop more


Qi Feng <[email protected]> 于2023年1月9日周一 20:32写道：
>
> From: fengqi <[email protected]>
>
> Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
> event is non-existent in current HID driver.
> So we add this event in hid-input.c
>
> Signed-off-by: fengqi <[email protected]>
> ---
> drivers/hid/hid-input.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 9b59e436df0a..22cca3406b5c 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -1105,6 +1105,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> case 0x0e5: map_key_clear(KEY_BASSBOOST); break;
> case 0x0e9: map_key_clear(KEY_VOLUMEUP); break;
> case 0x0ea: map_key_clear(KEY_VOLUMEDOWN); break;
> + case 0x0ee: map_key_clear(KEY_CAMERA_FOCUS); break;
> case 0x0f5: map_key_clear(KEY_SLOW); break;
>
> case 0x181: map_key_clear(KEY_BUTTONCONFIG); break;
> --
> 2.39.0
>

2023-01-12 02:59:26

by qi feng

Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID

please help me review this code

thanks a lot

qi feng <[email protected]> 于2023年1月10日周二 17:53写道：
>
> loop more
>
>
> Qi Feng <[email protected]> 于2023年1月9日周一 20:32写道：
> >
> > From: fengqi <[email protected]>
> >
> > Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
> > event is non-existent in current HID driver.
> > So we add this event in hid-input.c
> >
> > Signed-off-by: fengqi <[email protected]>
> > ---
> > drivers/hid/hid-input.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 9b59e436df0a..22cca3406b5c 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -1105,6 +1105,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> > case 0x0e5: map_key_clear(KEY_BASSBOOST); break;
> > case 0x0e9: map_key_clear(KEY_VOLUMEUP); break;
> > case 0x0ea: map_key_clear(KEY_VOLUMEDOWN); break;
> > + case 0x0ee: map_key_clear(KEY_CAMERA_FOCUS); break;
> > case 0x0f5: map_key_clear(KEY_SLOW); break;
> >
> > case 0x181: map_key_clear(KEY_BUTTONCONFIG); break;
> > --
> > 2.39.0
> >

2023-01-20 18:27:46

by Jiri Kosina

Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID

On Mon, 9 Jan 2023, Qi Feng wrote:

> From: fengqi <[email protected]>
>
> Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
> event is non-existent in current HID driver. So we add this event in
> hid-input.c
>
> Signed-off-by: fengqi <[email protected]>
> ---
> drivers/hid/hid-input.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index 9b59e436df0a..22cca3406b5c 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -1105,6 +1105,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> case 0x0e5: map_key_clear(KEY_BASSBOOST); break;
> case 0x0e9: map_key_clear(KEY_VOLUMEUP); break;
> case 0x0ea: map_key_clear(KEY_VOLUMEDOWN); break;
> + case 0x0ee: map_key_clear(KEY_CAMERA_FOCUS); break;
> case 0x0f5: map_key_clear(KEY_SLOW); break;
>
> case 0x181: map_key_clear(KEY_BUTTONCONFIG); break;

[ CCing Benjamin ]

Hi,

so according to HUT 1.3.0, 0xeb-0xef are Reserved for now, so I'd be a
little bit hesitatnt to but this into the generic mapping, as later HUT
revision might define this in a different way.

Which devices are known to be producing this?

--
Jiri Kosina
SUSE Labs

2023-01-29 02:59:26

by qi feng

Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID

Hi,
Our Bluetooth Handle needs the focus function, which is missing in the
current map
If our setting is unreasonable, do you have other suggested values

thanks

Jiri Kosina <[email protected]> 于2023年1月21日周六 01:51写道：
>
> On Mon, 9 Jan 2023, Qi Feng wrote:
>
> > From: fengqi <[email protected]>
> >
> > Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
> > event is non-existent in current HID driver. So we add this event in
> > hid-input.c
> >
> > Signed-off-by: fengqi <[email protected]>
> > ---
> > drivers/hid/hid-input.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 9b59e436df0a..22cca3406b5c 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -1105,6 +1105,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> > case 0x0e5: map_key_clear(KEY_BASSBOOST); break;
> > case 0x0e9: map_key_clear(KEY_VOLUMEUP); break;
> > case 0x0ea: map_key_clear(KEY_VOLUMEDOWN); break;
> > + case 0x0ee: map_key_clear(KEY_CAMERA_FOCUS); break;
> > case 0x0f5: map_key_clear(KEY_SLOW); break;
> >
> > case 0x181: map_key_clear(KEY_BUTTONCONFIG); break;
>
> [ CCing Benjamin ]
>
> Hi,
>
> so according to HUT 1.3.0, 0xeb-0xef are Reserved for now, so I'd be a
> little bit hesitatnt to but this into the generic mapping, as later HUT
> revision might define this in a different way.
>
> Which devices are known to be producing this?
>
> --
> Jiri Kosina
> SUSE Labs
>

2023-01-30 14:29:30

by Jiri Kosina

Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID

On Sun, 29 Jan 2023, qi feng wrote:

> Hi,
> Our Bluetooth Handle needs the focus function, which is missing in the
> current map
> If our setting is unreasonable, do you have other suggested values

If the device is under your control, wouldn't it be better to let it
produce something more defined by HID standard? (see e.g. 0x90 -- Camera
Control Page).

Thanks,

--
Jiri Kosina
SUSE Labs

2023-02-02 09:56:32

by qi feng

Subject: Re: [PATCH] HID: add KEY_CAMERA_FOCUS event in HID

I resubmitted V2 according to the standard, please help me to review it

thanks a lot

Jiri Kosina <[email protected]> 于2023年1月30日周一 22:28写道：
>
> On Sun, 29 Jan 2023, qi feng wrote:
>
> > Hi,
> > Our Bluetooth Handle needs the focus function, which is missing in the
> > current map
> > If our setting is unreasonable, do you have other suggested values
>
> If the device is under your control, wouldn't it be better to let it
> produce something more defined by HID standard? (see e.g. 0x90 -- Camera
> Control Page).
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>