2005-11-12 04:45:59

by Grant Coady

[permalink] [raw]
Subject: [RFC PATCH] Silence warning in cciss_scsi

Greetings,

From: Grant Coady <[email protected]>

Silence warning due to all callers being commented out:
drivers/block/cciss_scsi.c:264: warning: `print_bytes' defined but not used
drivers/block/cciss_scsi.c:298: warning: `print_cmd' defined but not used

compile tested with allmodconfig

Signed-off-by: Grant Coady <[email protected]>

---
cciss_scsi.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.15-rc1a/drivers/block/cciss_scsi.c~ 2005-11-12 13:51:12.000000000 +1100
+++ linux-2.6.15-rc1a/drivers/block/cciss_scsi.c 2005-11-12 15:36:01.000000000 +1100
@@ -255,7 +255,7 @@
#define DEVICETYPE(n) (n<0 || n>MAX_SCSI_DEVICE_CODE) ? \
"Unknown" : scsi_device_types[n]

-#if 1
+#if 0
static int xmargin=8;
static int amargin=60;

--
Thanks,
Grant.


2005-11-14 15:22:19

by Mike Miller

[permalink] [raw]
Subject: RE: [RFC PATCH] Silence warning in cciss_scsi



> -----Original Message-----
> From: Grant Coady [mailto:[email protected]]
> Sent: Friday, November 11, 2005 10:46 PM
> To: Miller, Mike (OS Dev)
> Cc: Andrew Morton; [email protected]
> Subject: [RFC PATCH] Silence warning in cciss_scsi
>
> Greetings,
>
> From: Grant Coady <[email protected]>
>
> Silence warning due to all callers being commented out:
> drivers/block/cciss_scsi.c:264: warning: `print_bytes'
> defined but not used
> drivers/block/cciss_scsi.c:298: warning: `print_cmd' defined
> but not used
>
> compile tested with allmodconfig
>
> Signed-off-by: Grant Coady <[email protected]>

Acked-by: Mike Miller <[email protected]>

>
> ---
> cciss_scsi.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.15-rc1a/drivers/block/cciss_scsi.c~
> 2005-11-12 13:51:12.000000000 +1100
> +++ linux-2.6.15-rc1a/drivers/block/cciss_scsi.c
> 2005-11-12 15:36:01.000000000 +1100
> @@ -255,7 +255,7 @@
> #define DEVICETYPE(n) (n<0 || n>MAX_SCSI_DEVICE_CODE) ? \
> "Unknown" : scsi_device_types[n]
>
> -#if 1
> +#if 0
> static int xmargin=8;
> static int amargin=60;
>
> --
> Thanks,
> Grant.
>