2020-04-30 08:35:11

by Kai-Heng Feng

Subject: [PATCH 2/3] ALSA: hda/realtek - Enable micmute LED on and HP system

Though the system uses DMIC, headset mic still uses the HDA, let's use
GPIO 0x1 to control the micmute LED.

The micmute LED GPIO has a different polarity to the mute LED GPIO, we
can use the newly added micmute_led_polarity to indicate that.

Signed-off-by: Kai-Heng Feng <[email protected]>
---
sound/pci/hda/patch_realtek.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3150a61befc5..6f164ccddde3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4134,7 +4134,11 @@ static void alc269_fixup_hp_gpio_led(struct hda_codec *codec,
static void alc285_fixup_hp_gpio_led(struct hda_codec *codec,
const struct hda_fixup *fix, int action)
{
- alc_fixup_hp_gpio_led(codec, action, 0x04, 0x00);
+ struct alc_spec *spec = codec->spec;
+
+ spec->micmute_led_polarity = 1;
+
+ alc_fixup_hp_gpio_led(codec, action, 0x04, 0x01);
}

static void alc286_fixup_hp_gpio_led(struct hda_codec *codec,
--
2.17.1

2020-04-30 17:25:32

by Takashi Iwai

Subject: Re: [PATCH 2/3] ALSA: hda/realtek - Enable micmute LED on and HP system

On Thu, 30 Apr 2020 10:32:52 +0200,
Kai-Heng Feng wrote:
>
> Though the system uses DMIC, headset mic still uses the HDA, let's use
> GPIO 0x1 to control the micmute LED.
>
> The micmute LED GPIO has a different polarity to the mute LED GPIO, we
> can use the newly added micmute_led_polarity to indicate that.
>
> Signed-off-by: Kai-Heng Feng <[email protected]>

Applied to for-next branch. Thanks.


Takashi