2021-07-20 14:14:55

by Yang Yingliang

Subject: [PATCH -next] ALSA: nm256: Fix error return code in snd_nm256_create()

If pci_request_regions() fails, it should return error
code in snd_nm256_create().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Yang Yingliang <[email protected]>
---
sound/pci/nm256/nm256.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/pci/nm256/nm256.c b/sound/pci/nm256/nm256.c
index a54b9b26a0c2..c9c178504959 100644
--- a/sound/pci/nm256/nm256.c
+++ b/sound/pci/nm256/nm256.c
@@ -1478,7 +1478,8 @@ snd_nm256_create(struct snd_card *card, struct pci_dev *pci)
chip->buffer_addr = pci_resource_start(pci, 0);
chip->cport_addr = pci_resource_start(pci, 1);

- if (pci_request_regions(pci, card->driver))
+ err = pci_request_regions(pci, card->driver);
+ if (err < 0)
return err;

/* Init the memory port info. */
--
2.25.1

2021-07-20 14:17:38

by Takashi Iwai

Subject: Re: [PATCH -next] ALSA: nm256: Fix error return code in snd_nm256_create()

On Tue, 20 Jul 2021 15:52:37 +0200,
Yang Yingliang wrote:
>
> If pci_request_regions() fails, it should return error
> code in snd_nm256_create().
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Yang Yingliang <[email protected]>

Thanks, applied.


Takashi