2022-05-09 06:57:17

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH] kernel/drivers: Remove redundant driver match function

Hello,

On Thu, May 05, 2022 at 09:59:52PM -0700, lizhe wrote:
> If there is no driver match function, the driver core assumes that each
> candidate pair (driver, device) matches, see driver_match_device().
>
> Signed-off-by: lizhe <[email protected]>

Reviewed-by: Uwe Kleine-K?nig <u.kleine-koenig.org>

Side note: While looking through this patch I was surprised to see there
are two different busses for ac97: sound/ac97/bus.c + sound/ac97_bus.c .
It seems the duplication exists since 2017.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (691.00 B)
signature.asc (499.00 B)
Download all attachments

2022-05-09 10:33:00

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] kernel/drivers: Remove redundant driver match function

On Fri, 06 May 2022 08:49:27 +0200,
Uwe Kleine-König wrote:
>
> Hello,
>
> On Thu, May 05, 2022 at 09:59:52PM -0700, lizhe wrote:
> > If there is no driver match function, the driver core assumes that each
> > candidate pair (driver, device) matches, see driver_match_device().
> >
> > Signed-off-by: lizhe <[email protected]>
>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig.org>
>
> Side note: While looking through this patch I was surprised to see there
> are two different busses for ac97: sound/ac97/bus.c + sound/ac97_bus.c .
> It seems the duplication exists since 2017.

Those are intentional and will be likely kept as-is. In theory those
could be unified, but there are quite lots of quirk codes for the old
bus implementations and it'll be way too much work to rewrite for the
new bus.


Takashi