2022-01-17 11:56:34

by Xiaoke Wang

Subject: [PATCH v2] nvmem: meson-mx-efuse: replace unnecessary devm_kstrdup()

From: Xiaoke Wang <[email protected]>

Replace unnecessary devm_kstrdup() so to avoid redundant memory allocation.

Suggested-by: Martin Blumenstingl <[email protected]>
Signed-off-by: Xiaoke Wang <[email protected]>
---
Changelogs:
Simplify the patch to replace unnecessary devm_kstrdup().
drivers/nvmem/meson-mx-efuse.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/nvmem/meson-mx-efuse.c b/drivers/nvmem/meson-mx-efuse.c
index 07c9f38..13eb143 100644
--- a/drivers/nvmem/meson-mx-efuse.c
+++ b/drivers/nvmem/meson-mx-efuse.c
@@ -209,8 +209,7 @@ static int meson_mx_efuse_probe(struct platform_device *pdev)
if (IS_ERR(efuse->base))
return PTR_ERR(efuse->base);

- efuse->config.name = devm_kstrdup(&pdev->dev, drvdata->name,
- GFP_KERNEL);
+ efuse->config.name = drvdata->name;
efuse->config.owner = THIS_MODULE;
efuse->config.dev = &pdev->dev;
efuse->config.priv = efuse;
--

2022-02-14 15:10:06

by Srinivas Kandagatla

Subject: Re: [PATCH v2] nvmem: meson-mx-efuse: replace unnecessary devm_kstrdup()

On 17/01/2022 02:56, [email protected] wrote:
> From: Xiaoke Wang <[email protected]>
>
> Replace unnecessary devm_kstrdup() so to avoid redundant memory allocation.
>
> Suggested-by: Martin Blumenstingl <[email protected]>
> Signed-off-by: Xiaoke Wang <[email protected]>

Applied thanks,

--srini
> ---
> Changelogs:
> Simplify the patch to replace unnecessary devm_kstrdup().
> drivers/nvmem/meson-mx-efuse.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/nvmem/meson-mx-efuse.c b/drivers/nvmem/meson-mx-efuse.c
> index 07c9f38..13eb143 100644
> --- a/drivers/nvmem/meson-mx-efuse.c
> +++ b/drivers/nvmem/meson-mx-efuse.c
> @@ -209,8 +209,7 @@ static int meson_mx_efuse_probe(struct platform_device *pdev)
> if (IS_ERR(efuse->base))
> return PTR_ERR(efuse->base);
>
> - efuse->config.name = devm_kstrdup(&pdev->dev, drvdata->name,
> - GFP_KERNEL);
> + efuse->config.name = drvdata->name;
> efuse->config.owner = THIS_MODULE;
> efuse->config.dev = &pdev->dev;
> efuse->config.priv = efuse;