2022-02-22 14:14:00

by Xiaoke Wang

Subject: [PATCH] ASoC: samsung: i2s: check the return value of kstrdup()

From: Xiaoke Wang <[email protected]>

kstrdup() is a memory allocation function which can return NULL when
some internal memory errors happen. It is better to check the return
value of it to catch the error in time.

Signed-off-by: Xiaoke Wang <[email protected]>
---
sound/soc/samsung/i2s.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
index 309badc..70c8271 100644
--- a/sound/soc/samsung/i2s.c
+++ b/sound/soc/samsung/i2s.c
@@ -1349,6 +1349,10 @@ static int i2s_create_secondary_device(struct samsung_i2s_priv *priv)
return -ENOMEM;

pdev_sec->driver_override = kstrdup("samsung-i2s", GFP_KERNEL);
+ if (!pdev_sec->driver_override) {
+ platform_device_put(pdev_sec);
+ return -ENOMEM;
+ }

ret = platform_device_add(pdev_sec);
if (ret < 0) {
--

2022-02-22 15:03:46

by Krzysztof Kozlowski

Subject: Re: [PATCH] ASoC: samsung: i2s: check the return value of kstrdup()

On 22/02/2022 12:53, [email protected] wrote:
> From: Xiaoke Wang <[email protected]>
>
> kstrdup() is a memory allocation function which can return NULL when
> some internal memory errors happen. It is better to check the return
> value of it to catch the error in time.
>
> Signed-off-by: Xiaoke Wang <[email protected]>
> ---
> sound/soc/samsung/i2s.c | 4 ++++
> 1 file changed, 4 insertions(+)
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof