LinuxLists.cc - fix: lp.c wrong return code

2002-02-24 17:33:15

Subject: fix: lp.c wrong return code

hi,
how takes care about the lp driver ? i saw some changes in the 2.4 but found no maintainer.
to the maintainer:
LPGETSTATS is strange. first you set LP_STAT then you delete it. maybe a EACCES (Permission denied) would do it ?

problem:
calling the ioctl( LPSETIRQ ) the driver returns EINVAL (Invalid argument)instead of ENOSYS.

Fix : return ENOSYS (Function not implemented)

NOTE:
if EINVAL is correct, you can delete the entiere entry, EINVAL in default.

Attachments:

(No filename) (466.00 B)
lp.diff (267.00 B)
Download all attachments

2002-02-24 19:43:50

by Alan

[permalink] [raw]

Subject: Re: fix: lp.c wrong return code

> calling the ioctl( LPSETIRQ ) the driver returns EINVAL (Invalid argument)instead of ENOSYS.
> Fix : return ENOSYS (Function not implemented)

ENOSYS is for a syscall not supported.

> if EINVAL is correct, you can delete the entiere entry, EINVAL in default.

It should actually be ENOTTY ...