2021-05-28 03:46:26

by Randy Dunlap

Subject: [PATCH] S390: appldata depends on PROC_SYSCTL

APPLDATA_BASE should depend on PROC_SYSCTL instead of PROC_FS.
Building with PROC_FS but not PROC_SYSCTL causes a build error,
since appldata_base.c uses data and APIs from fs/proc/proc_sysctl.c.

arch/s390/appldata/appldata_base.o: in function `appldata_generic_handler':
appldata_base.c:(.text+0x192): undefined reference to `sysctl_vals'

Fixes: c185b783b099 ("[S390] Remove config options.")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Heiko Carstens <[email protected]>
Cc: Vasily Gorbik <[email protected]>
Cc: Christian Borntraeger <[email protected]>
Cc: [email protected]
---
arch/s390/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20210526.orig/arch/s390/Kconfig
+++ linux-next-20210526/arch/s390/Kconfig
@@ -853,7 +853,7 @@ config CMM_IUCV
config APPLDATA_BASE
def_bool n
prompt "Linux - VM Monitor Stream, base infrastructure"
- depends on PROC_FS
+ depends on PROC_SYSCTL
help
This provides a kernel interface for creating and updating z/VM APPLDATA
monitor records. The monitor records are updated at certain time

2021-05-31 15:11:58

by Vasily Gorbik

Subject: Re: [PATCH] S390: appldata depends on PROC_SYSCTL

On Thu, May 27, 2021 at 05:24:20PM -0700, Randy Dunlap wrote:
> APPLDATA_BASE should depend on PROC_SYSCTL instead of PROC_FS.
> Building with PROC_FS but not PROC_SYSCTL causes a build error,
> since appldata_base.c uses data and APIs from fs/proc/proc_sysctl.c.
>
> arch/s390/appldata/appldata_base.o: in function `appldata_generic_handler':
> appldata_base.c:(.text+0x192): undefined reference to `sysctl_vals'
>
> Fixes: c185b783b099 ("[S390] Remove config options.")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Heiko Carstens <[email protected]>
> Cc: Vasily Gorbik <[email protected]>
> Cc: Christian Borntraeger <[email protected]>
> Cc: [email protected]
> ---
> arch/s390/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20210526.orig/arch/s390/Kconfig
> +++ linux-next-20210526/arch/s390/Kconfig
> @@ -853,7 +853,7 @@ config CMM_IUCV
> config APPLDATA_BASE
> def_bool n
> prompt "Linux - VM Monitor Stream, base infrastructure"
> - depends on PROC_FS
> + depends on PROC_SYSCTL
> help
> This provides a kernel interface for creating and updating z/VM APPLDATA
> monitor records. The monitor records are updated at certain time

Applied, thanks