2021-06-16 19:09:15

by Andy Shevchenko

[permalink] [raw]
Subject: [PATCH v1 1/1] scsi: imm: Switch to use module_parport_driver()

Switch to use module_parport_driver() to reduce boilerplate code.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/scsi/imm.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c
index 862d35a098cf..943c9102a7eb 100644
--- a/drivers/scsi/imm.c
+++ b/drivers/scsi/imm.c
@@ -1283,19 +1283,6 @@ static struct parport_driver imm_driver = {
.detach = imm_detach,
.devmodel = true,
};
-
-static int __init imm_driver_init(void)
-{
- printk("imm: Version %s\n", IMM_VERSION);
- return parport_register_driver(&imm_driver);
-}
-
-static void __exit imm_driver_exit(void)
-{
- parport_unregister_driver(&imm_driver);
-}
-
-module_init(imm_driver_init);
-module_exit(imm_driver_exit);
+module_parport_driver(imm_driver);

MODULE_LICENSE("GPL");
--
2.30.2


2021-06-19 08:59:10

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] scsi: imm: Switch to use module_parport_driver()


Andy,

> Switch to use module_parport_driver() to reduce boilerplate code.

Applied to 5.14/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering