2021-06-16 22:55:06

by Colin King

Subject: [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int

From: Colin Ian King <[email protected]>

The comparison of the u32 variable rc to less than zero always
false because it is unsigned. Fix this by making it an int.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/elx/libefc/efc_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/elx/libefc/efc_device.c b/drivers/scsi/elx/libefc/efc_device.c
index 31a688bce6e9..725ca2a23fb2 100644
--- a/drivers/scsi/elx/libefc/efc_device.c
+++ b/drivers/scsi/elx/libefc/efc_device.c
@@ -15,7 +15,7 @@
void
efc_d_send_prli_rsp(struct efc_node *node, u16 ox_id)
{
- u32 rc = EFC_SCSI_CALL_COMPLETE;
+ int rc = EFC_SCSI_CALL_COMPLETE;
struct efc *efc = node->efc;

node->ls_acc_oxid = ox_id;
--
2.31.1

2021-06-19 08:59:49

by Martin K. Petersen

Subject: Re: [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int

Colin,

> The comparison of the u32 variable rc to less than zero always false
> because it is unsigned. Fix this by making it an int.

Applied to 5.14/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2021-06-19 20:45:28

by James Smart

Subject: Re: [PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int

On 6/16/2021 10:04 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The comparison of the u32 variable rc to less than zero always
> false because it is unsigned. Fix this by making it an int.
>
> Addresses-Coverity: ("Unsigned compared against 0")
> Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/scsi/elx/libefc/efc_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!

Reviewed-by: James Smart <[email protected]>

-- james