2023-08-01 16:28:56

by Daniel Xu

Subject: Re: [PATCH] netfilter: bpf_link: avoid unused-function warning

Hi Arnd,

On Tue, Aug 01, 2023 at 05:02:41PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> The newly added function is unused in some random configurations:
>
> net/netfilter/nf_bpf_link.c:32:1: error: 'get_proto_defrag_hook' defined but not used [-Werror=unused-function]
> 32 | get_proto_defrag_hook(struct bpf_nf_link *link,
> | ^~~~~~~~~~~~~~~~~~~~~
>

This was fixed in 81584c23f249 ("netfilter: bpf: Only define get_proto_defrag_hook() if necessary").

Thanks,
Daniel

2023-08-01 18:31:14

by Arnd Bergmann

Subject: Re: [PATCH] netfilter: bpf_link: avoid unused-function warning

On Tue, Aug 1, 2023, at 17:20, Daniel Xu wrote:
> Hi Arnd,
>
> On Tue, Aug 01, 2023 at 05:02:41PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <[email protected]>
>>
>> The newly added function is unused in some random configurations:
>>
>> net/netfilter/nf_bpf_link.c:32:1: error: 'get_proto_defrag_hook' defined but not used [-Werror=unused-function]
>> 32 | get_proto_defrag_hook(struct bpf_nf_link *link,
>> | ^~~~~~~~~~~~~~~~~~~~~
>>
>
> This was fixed in 81584c23f249 ("netfilter: bpf: Only define
> get_proto_defrag_hook() if necessary").

Ok, I guess this will be in tomorrow's linux-next then, right?

Arnd

2023-08-01 20:52:08

by Daniel Xu

Subject: Re: [PATCH] netfilter: bpf_link: avoid unused-function warning

On Tue, Aug 01, 2023 at 07:27:33PM +0200, Arnd Bergmann wrote:
> On Tue, Aug 1, 2023, at 17:20, Daniel Xu wrote:
> > Hi Arnd,
> >
> > On Tue, Aug 01, 2023 at 05:02:41PM +0200, Arnd Bergmann wrote:
> >> From: Arnd Bergmann <[email protected]>
> >>
> >> The newly added function is unused in some random configurations:
> >>
> >> net/netfilter/nf_bpf_link.c:32:1: error: 'get_proto_defrag_hook' defined but not used [-Werror=unused-function]
> >> 32 | get_proto_defrag_hook(struct bpf_nf_link *link,
> >> | ^~~~~~~~~~~~~~~~~~~~~
> >>
> >
> > This was fixed in 81584c23f249 ("netfilter: bpf: Only define
> > get_proto_defrag_hook() if necessary").
>
> Ok, I guess this will be in tomorrow's linux-next then, right?
>
> Arnd

I'm not too familiar with the linux-next process, but chatgpt is telling
me it should be.

Thanks,
Daniel