Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759092Ab2KAUtf (ORCPT ); Thu, 1 Nov 2012 16:49:35 -0400 Received: from nat28.tlf.novell.com ([130.57.49.28]:41624 "EHLO nat28.tlf.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825Ab2KAUtd convert rfc822-to-8bit (ORCPT ); Thu, 1 Nov 2012 16:49:33 -0400 Message-Id: <5092E058020000780008EBA2@nat28.tlf.novell.com> X-Mailer: Novell GroupWise Internet Agent 12.0.0 Date: Thu, 01 Nov 2012 20:49:28 +0000 From: "Jan Beulich" To: , Cc: , , , , Subject: Re: linux-next: Tree for Oct 31 (ehci, dbgp) References: <5092D1AC020000780008EB60@nat28.tlf.novell.com> In-Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1095 Lines: 28 >>> Alan Stern 11/01/12 9:39 PM >>> >On Thu, 1 Nov 2012, Jan Beulich wrote: >> >>> Alan Stern 11/01/12 4:28 PM >>> >> >Evidently we need to change your new test in >> >drivers/usb/early/ehci-dbgp.c to: >> > >> >#if IS_ENABLED(CONFIG_USB_HCD_EHCI) || defined(CONFIG_USB_CHIPIDEA_HOST) >> > >> >Upcoming changes to ehci-hcd will make this unnecessary in 3.8, but for >> >now we need it. >> >> Which tells me that the CONFIG_USB_SUPPORT version would have been >> the better one (and I would favor that over the ugly variant you suggest >> above). > >I also suggested IS_ENABLED(CONFIG_USB), which is no uglier than what >you submitted and would also fix this build error. How about using it >instead? Yes, that's better. Question then is - updated original patch or incremental one? Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/