Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762291Ab2KAVYh (ORCPT ); Thu, 1 Nov 2012 17:24:37 -0400 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:35252 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759926Ab2KAVYf (ORCPT ); Thu, 1 Nov 2012 17:24:35 -0400 Date: Thu, 1 Nov 2012 21:29:43 +0000 From: Alan Cox To: Ondrej Zary Cc: alsa-devel@alsa-project.org, Kernel development list Subject: Re: [PATCH] snd-es1968: remove pm_whitelist Message-ID: <20121101212943.3f9fa50a@pyramind.ukuu.org.uk> In-Reply-To: <201211012155.54713.linux@rainbow-software.org> References: <201211012155.54713.linux@rainbow-software.org> X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.8; x86_64-redhat-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEWysKsSBQMIAwIZCwj///8wIhxoRDXH9QHCAAABeUlEQVQ4jaXTvW7DIBAAYCQTzz2hdq+rdg494ZmBeE5KYHZjm/d/hJ6NfzBJpp5kRb5PHJwvMPMk2L9As5Y9AmYRBL+HAyJKeOU5aHRhsAAvORQ+UEgAvgddj/lwAXndw2laEDqA4x6KEBhjYRCg9tBFCOuJFxg2OKegbWjbsRTk8PPhKPD7HcRxB7cqhgBRp9Dcqs+B8v4CQvFdqeot3Kov6hBUn0AJitrzY+sgUuiA8i0r7+B3AfqKcN6t8M6HtqQ+AOoELCikgQSbgabKaJW3kn5lBs47JSGDhhLKDUh1UMipwwinMYPTBuIBjEclSaGZUk9hDlTb5sUTYN2SFFQuPe4Gox1X0FZOufjgBiV1Vls7b+GvK3SU4wfmcGo9rPPQzgIabfj4TYQo15k3bTHX9RIw/kniir5YbtJF4jkFG+dsDK1IgE413zAthU/vR2HVMmFUPIHTvF6jWCpFaGw/A3qWgnbxpSm9MSmY5b3pM1gvNc/gQfwBsGwF0VCtxZgAAAAASUVORK5CYII= Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 755 Lines: 18 On Thu, 1 Nov 2012 21:55:54 +0100 Ondrej Zary wrote: > pm_whitelist breaks suspend on all non-whitelisted cards for unknown purpose. > Remove it. This fixes suspend on Terratec DMX and SF64-PCE2 cards. Because lots of them broke laptops. Why not just whitelist the ones you know works, given there are ones we know doesn't so your patch is an instant regression guarantee ? (and yes a blacklist might have been brighter but I don't know the history and it's a bit late to fix) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/