Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762426Ab2KAWZA (ORCPT ); Thu, 1 Nov 2012 18:25:00 -0400 Received: from natasha.panasas.com ([67.152.220.90]:39957 "EHLO natasha.panasas.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760695Ab2KAWY6 (ORCPT ); Thu, 1 Nov 2012 18:24:58 -0400 Message-ID: <5092F67A.2060203@panasas.com> Date: Thu, 1 Nov 2012 15:23:54 -0700 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: Jeff Layton CC: "Darrick J. Wong" , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 3/3] fs: Fix remaining filesystems to wait for stable page writeback References: <20121101075805.16153.64714.stgit@blackbox.djwong.org> <20121101075829.16153.92036.stgit@blackbox.djwong.org> <5092C2CE.7070209@panasas.com> <20121101162254.03dbbd9a@tlielax.poochiereds.net> In-Reply-To: <20121101162254.03dbbd9a@tlielax.poochiereds.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1058 Lines: 24 On 11/01/2012 01:22 PM, Jeff Layton wrote: > Hmm...I don't know... > > I've never been crazy about using the page lock for this, but in the > absence of a better way to guarantee stable pages, it was what I ended > up with at the time. cifs_writepages will hold the page lock until > kernel_sendmsg returns. At that point the TCP layer will have copied > off the page data so it's safe to release it. > > With this change though, we're going to end up blocking until the > writeback flag clears, right? And I think that will happen when the > reply comes in? So, we'll end up blocking for much longer than is > really necessary in page_mkwrite with this change. > Hmm OK, that is a very good point. In that case it is just a simple nack on Darrick's hunk to cifs. cifs is fine and should not be touched Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/