Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992630Ab2KAW7W (ORCPT ); Thu, 1 Nov 2012 18:59:22 -0400 Received: from usindpps06.hds.com ([207.126.252.19]:56495 "EHLO usindpps06.hds.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2992551Ab2KAW7S convert rfc822-to-8bit (ORCPT ); Thu, 1 Nov 2012 18:59:18 -0400 From: Seiji Aguchi To: "mikew@google.com" , "linux-kernel@vger.kernel.org" , "linux-efi@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "Luck, Tony (tony.luck@intel.com)" , "Matthew Garrett (mjg@redhat.com)" , "dzickus@redhat.com" CC: "dle-develop@lists.sourceforge.net" , Satoru Moriya Subject: [RESEND][PATCH v4 0/7] efi_pstore: multiple event logging support Thread-Topic: [RESEND][PATCH v4 0/7] efi_pstore: multiple event logging support Thread-Index: Ac24hHFAFvQEFsFDS+CaDx9ULcfkfw== Date: Thu, 1 Nov 2012 22:59:01 +0000 Message-ID: Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.74.43.113] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.7.7855,1.0.431,0.0.0000 definitions=2012-11-01_07:2012-11-01,2012-11-01,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=0 spamscore=0 ipscore=0 suspectscore=11 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=6.0.2-1203120001 definitions=main-1211010268 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3030 Lines: 74 Changelog v3 -> v4 - Rebase to 3.7-rc3 - Add ctime to an argument of efi_pstore_erase to build successfully in case where CONFIG_PTORE=n is specified. (Patch 4/7) - Add count to an argument of efi_pstore_erase and efi_pstore_write to build successfully in case where CONFIG_PTORE=n is specified (Patch 5/7) - Fix a white space damage (Patch 6/7) - Modify a logic checking a 3-variable format of a variable name (Patch 7/7) v2 -> v3 - Create patches 6/7 and 7/7 to work with an existing format of variable name v1 -> v2 - Separate into 5 patches in accordance with Mike's comment - Erase an extra line of comment in patch 1/5 [Issue] Currently, efi_pstore driver simply overwrites existing panic messages in NVRAM. So, in the following scenario, we will lose 1st panic messages. 1. kernel panics. 2. efi_pstore is kicked and writes panic messages to NVRAM. 3. system reboots. 4. kernel panics again before a user checks the 1st panic messages in NVRAM. [Solution] Solutions of this problem has been discussed among Tony, Matthew, Don, Mike and me. http://marc.info/?l=linux-kernel&m=134273270704586&w=2 And there are two possible solutions right now. - First one is introducing some policy overwriting existing logs. - Second one is simply holding multiple log without overwriting any entries. We haven't decided the overwriting policy which is reasonable to all users yet. But I believe we agree that just holding multiple logs is a reasonable way. We may need further discussions to find the possibility of introducing overwriting policy, especially getting critical messages in multiple oops case. But I would like to begin with a simple and reasonable way to everyone. So, this patch takes an approach just holding multiple logs. [Patch Description] Seiji Aguchi (7): efi_pstore: Check remaining space with QueryVariableInfo() before writing data efi_pstore: Add a logic erasing entries to an erase callback efi_pstore: Remove a logic erasing entries from a write callback to hold multiple logs efi_pstore: Add ctime to argument of erase callback efi_pstore: Add a sequence counter to a variable name efi_pstore: Add a format check for an existing variable name at reading time Add a format check for an existing variable name at erasing time drivers/acpi/apei/erst.c | 16 ++-- drivers/firmware/efivars.c | 163 ++++++++++++++++++++++++++++++------------- fs/pstore/inode.c | 7 ++- fs/pstore/internal.h | 2 +- fs/pstore/platform.c | 11 ++-- fs/pstore/ram.c | 9 +-- include/linux/efi.h | 1 + include/linux/pstore.h | 6 +- 8 files changed, 143 insertions(+), 72 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/