Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932898Ab2KBJeF (ORCPT ); Fri, 2 Nov 2012 05:34:05 -0400 Received: from smtp-out-184.synserver.de ([212.40.185.184]:1204 "EHLO smtp-out-184.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932666Ab2KBJeC (ORCPT ); Fri, 2 Nov 2012 05:34:02 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 12507 Message-ID: <50939378.2050500@metafoo.de> Date: Fri, 02 Nov 2012 10:33:44 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.10) Gecko/20121027 Icedove/10.0.10 MIME-Version: 1.0 To: Josh Cartwright CC: Grant Likely , Rob Herring , Russell King , Mike Turquette , John Stultz , Thomas Gleixner , Alan Cox , Greg Kroah-Hartman , John Linn , Michal Simek , devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Michal Simek Subject: Re: [PATCH 5/8] ARM: zynq: add COMMON_CLK support References: <94af5ee92c2d68f245eb902de74909aadf159be1.1351721190.git.josh.cartwright@ni.com> In-Reply-To: <94af5ee92c2d68f245eb902de74909aadf159be1.1351721190.git.josh.cartwright@ni.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2263 Lines: 77 On 10/31/2012 07:58 PM, Josh Cartwright wrote: > [...] > +#define PERIPH_CLK_CTRL_SRC(x) (periph_clk_parent_map[((x)&3)>>4]) > +#define PERIPH_CLK_CTRL_DIV(x) (((x)&0x3F00)>>8) A few more spaces wouldn't hurt ;) > [...] > +static void __init zynq_periph_clk_setup(struct device_node *np) > +{ > + struct zynq_periph_clk *periph; > + const char *parent_names[3]; > + struct clk_init_data init; > + struct clk *clk; > + int err; > + u32 reg; > + int i; > + > + err = of_property_read_u32(np, "reg", ®); > + WARN_ON(err); Shouldn't the function abort if a error happens somewhere? Continuing here will lead to undefined behavior. Same is probably true for the other WARN_ONs. > + > + periph = kzalloc(sizeof(*periph), GFP_KERNEL); > + WARN_ON(!periph); > + > + periph->clk_ctrl = slcr_base + reg; > + spin_lock_init(&periph->clkact_lock); > + > + init.name = np->name; > + init.ops = &zynq_periph_clk_ops; > + for (i = 0; i < ARRAY_SIZE(parent_names); i++) > + parent_names[i] = of_clk_get_parent_name(np, i); > + init.parent_names = parent_names; > + init.num_parents = ARRAY_SIZE(parent_names); > + > + periph->hw.init = &init; > + > + clk = clk_register(NULL, &periph->hw); > + WARN_ON(IS_ERR(clk)); > + > + err = of_clk_add_provider(np, of_clk_src_simple_get, clk); > + WARN_ON(err); > + > + for (i = 0; i < 2; i++) { Not all of the peripheral clock generators have two output clocks. I think it makes sense to use the number entries in clock-output-names here. > + const char *name; > + > + err = of_property_read_string_index(np, "clock-output-names", i, > + &name); > + WARN_ON(err); > + > + periph->gates[i] = clk_register_gate(NULL, name, np->name, 0, > + periph->clk_ctrl, i, 0, > + &periph->clkact_lock); > + WARN_ON(IS_ERR(periph->gates[i])); > + } > + > + periph->onecell_data.clks = periph->gates; > + periph->onecell_data.clk_num = i; > + > + err = of_clk_add_provider(np, of_clk_src_onecell_get, > + &periph->onecell_data); > + WARN_ON(err); > +} > [...] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/