Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761270Ab2KBMrT (ORCPT ); Fri, 2 Nov 2012 08:47:19 -0400 Received: from e3.ny.us.ibm.com ([32.97.182.143]:53338 "EHLO e3.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752029Ab2KBMrR (ORCPT ); Fri, 2 Nov 2012 08:47:17 -0400 Date: Fri, 2 Nov 2012 18:20:55 +0530 From: Srikar Dronamraju To: Oleg Nesterov Cc: Ananth N Mavinakayanahalli , Sebastian Andrzej Siewior , Anton Arapov , Benjamin Herrenschmidt , Ingo Molnar , Peter Zijlstra , Rabin Vincent , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] uprobes: Kill arch_uprobe_enable/disable_step() hooks Message-ID: <20121102125055.GF11125@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20121028173900.GA14621@redhat.com> <20121028173936.GA14659@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20121028173936.GA14659@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 12110212-8974-0000-0000-0000107FAA39 X-IBM-ISS-SpamDetectors: X-IBM-ISS-DetailInfo: BY=3.00000294; HX=3.00000198; KW=3.00000007; PH=3.00000001; SC=3.00000008; SDB=6.00187806; UDB=6.00042536; UTC=2012-11-02 12:47:15 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2573 Lines: 72 * Oleg Nesterov [2012-10-28 18:39:36]: > Kill arch_uprobe_enable/disable_step() hooks, they do nothing and > nobody needs them. > > Signed-off-by: Oleg Nesterov Acked-by: Srikar Dronamraju > --- > include/linux/uprobes.h | 2 -- > kernel/events/uprobes.c | 10 ---------- > 2 files changed, 0 insertions(+), 12 deletions(-) > > diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h > index 2459457..2615c4d 100644 > --- a/include/linux/uprobes.h > +++ b/include/linux/uprobes.h > @@ -101,8 +101,6 @@ extern void uprobe_dup_mmap(struct mm_struct *oldmm, struct mm_struct *newmm); > extern void uprobe_free_utask(struct task_struct *t); > extern void uprobe_copy_process(struct task_struct *t); > extern unsigned long __weak uprobe_get_swbp_addr(struct pt_regs *regs); > -extern void __weak arch_uprobe_enable_step(struct arch_uprobe *arch); > -extern void __weak arch_uprobe_disable_step(struct arch_uprobe *arch); > extern int uprobe_post_sstep_notifier(struct pt_regs *regs); > extern int uprobe_pre_sstep_notifier(struct pt_regs *regs); > extern void uprobe_notify_resume(struct pt_regs *regs); > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index 916391e..02d7c5f 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -1430,14 +1430,6 @@ static struct uprobe *find_active_uprobe(unsigned long bp_vaddr, int *is_swbp) > return uprobe; > } > > -void __weak arch_uprobe_enable_step(struct arch_uprobe *arch) > -{ > -} > - > -void __weak arch_uprobe_disable_step(struct arch_uprobe *arch) > -{ > -} > - > /* > * Run handler and ask thread to singlestep. > * Ensure all non-fatal signals cannot interrupt thread while it singlesteps. > @@ -1491,7 +1483,6 @@ static void handle_swbp(struct pt_regs *regs) > goto out; > > if (!pre_ssout(uprobe, regs, bp_vaddr)) { > - arch_uprobe_enable_step(&uprobe->arch); > utask->active_uprobe = uprobe; > utask->state = UTASK_SSTEP; > return; > @@ -1523,7 +1514,6 @@ static void handle_singlestep(struct uprobe_task *utask, struct pt_regs *regs) > else > WARN_ON_ONCE(1); > > - arch_uprobe_disable_step(&uprobe->arch); > put_uprobe(uprobe); > utask->active_uprobe = NULL; > utask->state = UTASK_RUNNING; > -- > 1.5.5.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/