Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933648Ab2KBOCD (ORCPT ); Fri, 2 Nov 2012 10:02:03 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:38615 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752209Ab2KBOCA (ORCPT ); Fri, 2 Nov 2012 10:02:00 -0400 Date: Fri, 2 Nov 2012 10:01:58 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Jan Beulich cc: gregkh@linuxfoundation.org, , , , , Subject: Re: linux-next: Tree for Oct 31 (ehci, dbgp) In-Reply-To: <5092E058020000780008EBA2@nat28.tlf.novell.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1276 Lines: 33 On Thu, 1 Nov 2012, Jan Beulich wrote: > >>> Alan Stern 11/01/12 9:39 PM >>> > >On Thu, 1 Nov 2012, Jan Beulich wrote: > >> >>> Alan Stern 11/01/12 4:28 PM >>> > >> >Evidently we need to change your new test in > >> >drivers/usb/early/ehci-dbgp.c to: > >> > > >> >#if IS_ENABLED(CONFIG_USB_HCD_EHCI) || defined(CONFIG_USB_CHIPIDEA_HOST) > >> > > >> >Upcoming changes to ehci-hcd will make this unnecessary in 3.8, but for > >> >now we need it. > >> > >> Which tells me that the CONFIG_USB_SUPPORT version would have been > >> the better one (and I would favor that over the ugly variant you suggest > >> above). > > > >I also suggested IS_ENABLED(CONFIG_USB), which is no uglier than what > >you submitted and would also fix this build error. How about using it > >instead? > > Yes, that's better. Question then is - updated original patch or incremental one? Greg will probably want an incremental patch, because the original has already been merged. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/