Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757169Ab2KBPeL (ORCPT ); Fri, 2 Nov 2012 11:34:11 -0400 Received: from exprod5og114.obsmtp.com ([64.18.0.28]:46814 "EHLO exprod5og114.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206Ab2KBPeH (ORCPT ); Fri, 2 Nov 2012 11:34:07 -0400 Message-ID: <5093E57B.2020801@ge.com> Date: Fri, 02 Nov 2012 15:23:39 +0000 From: Martyn Welch User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 MIME-Version: 1.0 To: Wei Yongjun CC: manohar.vanga@gmail.com, gregkh@linuxfoundation.org, yongjun_wei@trendmicro.com.cn, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vme: vme_vmivme7805.c: use module_pci_driver to simplify the code References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 02 Nov 2012 15:23:41.0950 (UTC) FILETIME=[0A7171E0:01CDB90E] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2338 Lines: 76 On 18/10/2012 16:15, Wei Yongjun wrote: > From: Wei Yongjun > > Use the module_pci_driver() macro to make the code simpler > by eliminating module_init and module_exit calls. > > dpatch engine is used to auto generate this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun Acked-by: Martyn Welch > --- > drivers/vme/boards/vme_vmivme7805.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/drivers/vme/boards/vme_vmivme7805.c b/drivers/vme/boards/vme_vmivme7805.c > index 8e05bb4..dd22b50 100644 > --- a/drivers/vme/boards/vme_vmivme7805.c > +++ b/drivers/vme/boards/vme_vmivme7805.c > @@ -19,10 +19,8 @@ > > #include "vme_vmivme7805.h" > > -static int __init vmic_init(void); > static int vmic_probe(struct pci_dev *, const struct pci_device_id *); > static void vmic_remove(struct pci_dev *); > -static void __exit vmic_exit(void); > > /** Base address to access FPGA register */ > static void *vmic_base; > @@ -41,11 +39,6 @@ static struct pci_driver vmic_driver = { > .remove = vmic_remove, > }; > > -static int __init vmic_init(void) > -{ > - return pci_register_driver(&vmic_driver); > -} > - > static int vmic_probe(struct pci_dev *pdev, const struct pci_device_id *id) > { > int retval; > @@ -109,15 +102,9 @@ static void vmic_remove(struct pci_dev *pdev) > > } > > -static void __exit vmic_exit(void) > -{ > - pci_unregister_driver(&vmic_driver); > -} > +module_pci_driver(vmic_driver); > > MODULE_DESCRIPTION("VMIVME-7805 board support driver"); > MODULE_AUTHOR("Arthur Benilov "); > MODULE_LICENSE("GPL"); > > -module_init(vmic_init); > -module_exit(vmic_exit); > - > > -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.welch@ge.com | VAT:GB 927559189 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/