Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763268Ab2KBRo6 (ORCPT ); Fri, 2 Nov 2012 13:44:58 -0400 Received: from a193-30.smtp-out.amazonses.com ([199.255.193.30]:4841 "EHLO a193-30.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759255Ab2KBRo5 (ORCPT ); Fri, 2 Nov 2012 13:44:57 -0400 Date: Fri, 2 Nov 2012 17:44:55 +0000 From: Christoph Lameter X-X-Sender: cl@gentwo.org To: Shan Wei cc: David Miller , timo.teras@iki.fi, steffen.klassert@secunet.com, NetDev , Kernel-Maillist Subject: Re: [PATCH v2 1/9] net: core: use this_cpu_ptr per-cpu helper In-Reply-To: <5093EE47.20700@gmail.com> Message-ID: <0000013ac239c004-87f4c3e0-5c6a-4979-817f-0a0c4445a4e9-000000@email.amazonses.com> References: <5093EE47.20700@gmail.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-SES-Outgoing: 199.255.193.30 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 740 Lines: 19 On Sat, 3 Nov 2012, Shan Wei wrote: > +++ b/net/core/flow.c > @@ -327,11 +327,9 @@ static void flow_cache_flush_tasklet(unsigned long data) > static void flow_cache_flush_per_cpu(void *data) > { > struct flow_flush_info *info = data; > - int cpu; > struct tasklet_struct *tasklet; > > - cpu = smp_processor_id(); > - tasklet = &per_cpu_ptr(info->cache->percpu, cpu)->flush_tasklet; > + tasklet = &this_cpu_ptr(info->cache->percpu)->flush_tasklet Another case for the use of this_cpu_read -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/