Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672Ab2KCFkx (ORCPT ); Sat, 3 Nov 2012 01:40:53 -0400 Received: from mail-ia0-f174.google.com ([209.85.210.174]:48450 "EHLO mail-ia0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790Ab2KCFkw (ORCPT ); Sat, 3 Nov 2012 01:40:52 -0400 MIME-Version: 1.0 In-Reply-To: <20121102182926.GA18824@kroah.com> References: <1351836952-3389-1-git-send-email-luca.clementi@gmail.com> <20121102182926.GA18824@kroah.com> Date: Fri, 2 Nov 2012 22:40:51 -0700 Message-ID: Subject: Re: [PATCH] Staging: Android: logger: module_exit implementationg From: Brian Swetland To: Greg Kroah-Hartman Cc: Luca Clementi , linux-kernel@vger.kernel.org, Robert Love Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 29 On Fri, Nov 2, 2012 at 11:29 AM, Greg Kroah-Hartman wrote: > On Thu, Nov 01, 2012 at 11:15:52PM -0700, Luca Clementi wrote: >> + >> + >> +module_init(logger_init); > > Is module_init() the same "level" as device_initcall()? Did you test > this out in an Android system? > >> +module_exit(logger_exit); >> +MODULE_LICENSE("GPL"); >> +MODULE_AUTHOR("Brian Swetland, "); >> +MODULE_DESCRIPTION("Android Logger"); >> + >> + > > What's with the unneeded trailing empty lines? Also, module author should be Robert Love (cc'd), unless he'd rather not be credited, in which case "Google, Inc" or no listed author is fine. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/