Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751660Ab2KDI33 (ORCPT ); Sun, 4 Nov 2012 03:29:29 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60114 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750922Ab2KDI31 (ORCPT ); Sun, 4 Nov 2012 03:29:27 -0500 Date: Sun, 04 Nov 2012 09:29:25 +0100 Message-ID: From: Takashi Iwai To: Ondrej Zary Cc: Alan Cox , alsa-devel@alsa-project.org, Kernel development list Subject: Re: [alsa-devel] [PATCH] snd-es1968: remove pm_whitelist In-Reply-To: <201211012258.31310.linux@rainbow-software.org> References: <201211012155.54713.linux@rainbow-software.org> <20121101212943.3f9fa50a@pyramind.ukuu.org.uk> <201211012258.31310.linux@rainbow-software.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1764 Lines: 48 At Thu, 1 Nov 2012 22:58:30 +0100, Ondrej Zary wrote: > > On Thursday 01 November 2012 22:29:43 Alan Cox wrote: > > On Thu, 1 Nov 2012 21:55:54 +0100 > > > > Ondrej Zary wrote: > > > pm_whitelist breaks suspend on all non-whitelisted cards for unknown > > > purpose. Remove it. This fixes suspend on Terratec DMX and SF64-PCE2 > > > cards. > > > > Because lots of them broke laptops. > > > > Why not just whitelist the ones you know works, given there are ones we > > know doesn't so your patch is an instant regression guarantee ? > > > > (and yes a blacklist might have been brighter but I don't know the > > history and it's a bit late to fix) > > I wonder what does the suspend/resume code break? Currently, all > non-whitelisted cards are broken (not working after resume). You can't expect anything logical with the broken ACPI support on such old hardware :) > The problem with adding cards to the whitelist is that Terratec DMX has > generic subsystem ID: > ESS Technology ES1978 Maestro 2E [125d:1978] (rev 10) > Subsystem: ESS Technology ES1978 Maestro 2E [125d:1978] > > Adding this to the whitelist does not look like a good idea... But better than possibly breaking all units without testing. The fact that the device contains only the ES1978 SSID implies that it's a PCI sound card, not an on-board device. Thus the possibility to regress for such a case is fairly low. The concern is basically only for the onboard sound devices on old laptops. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/