Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753199Ab2KDRoL (ORCPT ); Sun, 4 Nov 2012 12:44:11 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:34220 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285Ab2KDRoI (ORCPT ); Sun, 4 Nov 2012 12:44:08 -0500 MIME-Version: 1.0 In-Reply-To: <1352050506-29317-1-git-send-email-matt@console-pimps.org> References: <1352050506-29317-1-git-send-email-matt@console-pimps.org> Date: Sun, 4 Nov 2012 17:44:05 +0000 X-Google-Sender-Auth: WPAM_f-lFJqxXF9wlF0VwyUa5TE Message-ID: Subject: Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y From: Corentin Chary To: Matt Fleming Cc: Matthew Garrett , LKML , linux-efi@vger.kernel.org, "platform-driver-x86@vger.kernel.org" , Alessandro Crismani , Mikhail Bakhterev , Patrick H , Matt Fleming , "H. Peter Anvin" , stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2003 Lines: 57 On Sun, Nov 4, 2012 at 5:35 PM, Matt Fleming wrote: > From: Matt Fleming > > We've started getting reports of users seeing Machine Check Exceptions > when booting their Samsung laptops in UEFI mode, > > https://bugzilla.kernel.org/show_bug.cgi?id=47121 > > This module seems to be the culprit as it's grovelling around in the > 0xf0000 region which has no mapping in either the e820 or EFI memory > maps on the affected machines. > > Reported-by: Alessandro Crismani > Reported-by: Mikhail Bakhterev > Tested-by: Patrick H > Cc: H. Peter Anvin > Cc: Matthew Garrett > Cc: Corentin Chary > Cc: stable@vger.kernel.org > Signed-off-by: Matt Fleming > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index c86bae8..0fe5200 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -717,7 +717,7 @@ config XO15_EBOOK > > config SAMSUNG_LAPTOP > tristate "Samsung Laptop driver" > - depends on X86 > + depends on X86 && !EFI > depends on RFKILL || RFKILL = n > depends on BACKLIGHT_CLASS_DEVICE > select LEDS_CLASS > -- > 1.7.11.7 > Acked-by: Corentin Chary Matthew could you merge this in your tree ? Thanks. Matt, any idea if SABI doesn't exist on these machines, or is just mapped somewhere else ? By any luck, could Samsung tell you how to safely detect SABI aware machines ? -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/