MIME-Version: 1.0
In-Reply-To: <1351666855-23854-2-git-send-email-yuanhan.liu@linux.intel.com>
References: <1351666855-23854-1-git-send-email-yuanhan.liu@linux.intel.com>
	<1351666855-23854-2-git-send-email-yuanhan.liu@linux.intel.com>
Date: Sun, 4 Nov 2012 18:47:12 +0100
Message-ID: <CACRpkdapHWJAMFn0hUQF52RjBz38MZzD3GS+5+pLfhsKJ+p_GQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] gpio: do not call __gpio_xxx under !CONFIG_GPIOLIB
From: Linus Walleij <linus.walleij@linaro.org>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Grant Likely <grant.likely@secretlab.ca>,
        Fengguang Wu <fengguang.wu@intel.com>
Content-Type: text/plain; charset=ISO-8859-1
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1282
Lines: 40

On Wed, Oct 31, 2012 at 8:00 AM, Yuanhan Liu
<yuanhan.liu@linux.intel.com> wrote:

> Those functions are availabe only when CONFIG_GPIOLIB is set. So, we
> should not call them under !CONFIG_GPIOLIB block.
>
> This would fix following build errros:
> include/asm-generic/gpio.h: In function 'gpio_get_value_cansleep':
> include/asm-generic/gpio.h:220:2: error: implicit declaration of function '__gpio_get_value'
> include/asm-generic/gpio.h: In function 'gpio_set_value_cansleep':
> nclude/asm-generic/gpio.h:226:2: error: implicit declaration of function '__gpio_set_value'

OK...

>  static inline int gpio_get_value_cansleep(unsigned gpio)
>  {
> -       might_sleep();

So why are you deleting this very useful might_sleep() runtime
semantic check?

> -       return __gpio_get_value(gpio);
> +       WARN_ON(1);
> +       return 0;
>  }
>
>  static inline void gpio_set_value_cansleep(unsigned gpio, int value)
>  {
> -       might_sleep();
> -       __gpio_set_value(gpio, value);
> +       WARN_ON(1);
>  }

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/