Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752675Ab2KDSOM (ORCPT ); Sun, 4 Nov 2012 13:14:12 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:37734 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751650Ab2KDSOG (ORCPT ); Sun, 4 Nov 2012 13:14:06 -0500 Message-ID: <1352052841.14888.190.camel@mfleming-mobl1.ger.corp.intel.com> Subject: Re: [PATCH] x86: remove dummy long from EFI stub From: Matt Fleming To: Cesar Eduardo Barros Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Jordan Justen , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar Date: Sun, 04 Nov 2012 18:14:01 +0000 In-Reply-To: <1351377255-21092-2-git-send-email-cesarb@cesarb.net> References: <1351377255-21092-2-git-send-email-cesarb@cesarb.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1316 Lines: 39 On Sat, 2012-10-27 at 20:34 -0200, Cesar Eduardo Barros wrote: > Commit 2e064b1 (x86, efi: Fix issue of overlapping .reloc section for > EFI_STUB) removed a dummy reloc added by commit 291f363 (x86, efi: EFI > boot stub support), but forgot to remove the dummy long used by that > reloc. > > Cc: Jordan Justen > Cc: Matt Fleming > Cc: "H. Peter Anvin" > Cc: Thomas Gleixner > Cc: Ingo Molnar > Signed-off-by: Cesar Eduardo Barros > --- > arch/x86/boot/header.S | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/x86/boot/header.S b/arch/x86/boot/header.S > index 2a01744..8c132a6 100644 > --- a/arch/x86/boot/header.S > +++ b/arch/x86/boot/header.S > @@ -476,6 +476,3 @@ die: > setup_corrupt: > .byte 7 > .string "No setup signature found...\n" > - > - .data > -dummy: .long 0 This change seems fine to me. Jordan, would you mind ACKing this if you're OK with it? -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/