Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752099Ab2KEAdN (ORCPT ); Sun, 4 Nov 2012 19:33:13 -0500 Received: from mail-da0-f46.google.com ([209.85.210.46]:60909 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867Ab2KEAdJ (ORCPT ); Sun, 4 Nov 2012 19:33:09 -0500 MIME-Version: 1.0 In-Reply-To: References: <509391CA.9040408@ti.com> From: Grant Likely Date: Mon, 5 Nov 2012 00:32:48 +0000 X-Google-Sender-Auth: 6xCXcS7lWdSVdTgvA9Z8eXyBS-A Message-ID: Subject: Re: [PATCH 0/3] capebus moving omap_devices to mach-omap2 To: Koen Kooi Cc: "Cousson, Benoit" , Jason Kridner , Tony Lindgren , paul@pwsan.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, "Porter, Matt" , Russ Dill , khilman@ti.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1125 Lines: 24 On Fri, Nov 2, 2012 at 10:19 AM, Koen Kooi wrote: > button@1 { > debounce_interval = <50>; > linux,code = <105>; > label = "left"; > gpios = <&gpio2 16 0x0>; > gpio-key,wakeup; > autorepeat; > }; > > Is the "linux,code" pure hardware or have there already been exceptions to that rule? I generally push back on "linux,blah" bindings since they have the tendency to change over time when someone changes the driver. However, since the keycodes are part of the Linux userspace ABI, and are therefore pretty much set it stone, I didn't object to the linux,keycode binding. There are already drivers using it. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/