Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753808Ab2KEJMI (ORCPT ); Mon, 5 Nov 2012 04:12:08 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:48750 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753625Ab2KEJMD (ORCPT ); Mon, 5 Nov 2012 04:12:03 -0500 MIME-Version: 1.0 In-Reply-To: <20121104193741.7b4ca37b@pyramind.ukuu.org.uk> References: <1352050506-29317-1-git-send-email-matt@console-pimps.org> <20121104193741.7b4ca37b@pyramind.ukuu.org.uk> Date: Mon, 5 Nov 2012 09:12:01 +0000 X-Google-Sender-Auth: JZplNr2ypZFiMYpKUCOhmkgIssE Message-ID: Subject: Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y From: Corentin Chary To: Alan Cox Cc: Matt Fleming , Matthew Garrett , LKML , linux-efi@vger.kernel.org, "platform-driver-x86@vger.kernel.org" , Alessandro Crismani , Mikhail Bakhterev , Patrick H , Matt Fleming , "H. Peter Anvin" , stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 27 On Sun, Nov 4, 2012 at 7:37 PM, Alan Cox wrote: >> Acked-by: Corentin Chary > > This is totally bogus and prevents users build a kernel which can work in > either mode. As such its a regression. Arg.. Sorry for that, I didn't realized that CONFIG_EFI=y was not something rare these days. > Do the detection check at runtime. If it was booted via EFI then don't > grovel in places you shouldn't. Indeed its possible EFI should reserve > those memory regions ? I wonder how the windows driver works in this case.. Maybe they use something completly different, and the SABI interface is still there because nobody removed/disabled it ? In this case it's probably not a good idea to use it on these machines since the implementation is likely to be completly broken. -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/