Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754112Ab2KEK6L (ORCPT ); Mon, 5 Nov 2012 05:58:11 -0500 Received: from cpsmtpb-ews10.kpnxchange.com ([213.75.39.15]:55959 "EHLO cpsmtpb-ews10.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136Ab2KEK6J (ORCPT ); Mon, 5 Nov 2012 05:58:09 -0500 Message-ID: <1352113082.1434.31.camel@x61.thuisdomein> Subject: [PATCH] [SCSI] advansys: change buildtime warning into runtime error From: Paul Bolle To: Matthew Wilcox , "James E.J. Bottomley" Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 05 Nov 2012 11:58:02 +0100 Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 05 Nov 2012 10:58:02.0989 (UTC) FILETIME=[6D5241D0:01CDBB44] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2405 Lines: 57 Building advansys.o triggers this warning: drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not properly converted to the DMA API [-Wcpp] This warning can be traced back to a patch called "advansys: add warning and convert #includes" which was included in v2.6.10. That patch also marked the driver as BROKEN. Commit 4661e3eace2c7b8433476b5bf0ee437ab3c7dfd4 ("[SCSI] advansys driver: limp along on x86") enabled this driver for x86-32. And commit 9d511a4b29de6764931343d03e493f2e04df0271 ("[SCSI] advansys: Changes to work on parisc") enabled this driver for all architectures. But the commit explanation stated: I haven't removed the #warning yet because virt_to_bus/bus_to_virt are only eliminated for narrow boards. Wide boards need more work. Five years have passed and, apparently, those wide boards still need more work. So let's change the buildtime warning into a runtime error, only printed for those wide boards. Perhaps that might push the people using those wide boards to convert this driver. And for all others there's now one less buildtime warning to ignore. Signed-off-by: Paul Bolle --- Compile tested only. I don't have any AdvanSys SCSI boards (neither narrow nor wide). drivers/scsi/advansys.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index 374c4ed..23d347d 100644 --- a/drivers/scsi/advansys.c +++ b/drivers/scsi/advansys.c @@ -68,7 +68,6 @@ * 7. advansys_info is not safe against multiple simultaneous callers * 8. Add module_param to override ISA/VLB ioport array */ -#warning this driver is still not properly converted to the DMA API /* Enable driver /proc statistics. */ #define ADVANSYS_STATS @@ -12772,6 +12771,7 @@ advansys_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) pdev->device == PCI_DEVICE_ID_38C0800_REV1 || pdev->device == PCI_DEVICE_ID_38C1600_REV1) { board->flags |= ASC_IS_WIDE_BOARD; + pr_err("This driver is still not properly converted to the DMA API"); } err = advansys_board_found(shost, ioport, ASC_IS_PCI); -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/