Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932379Ab2KEN24 (ORCPT ); Mon, 5 Nov 2012 08:28:56 -0500 Received: from mail-la0-f46.google.com ([209.85.215.46]:51939 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932357Ab2KEN2x (ORCPT ); Mon, 5 Nov 2012 08:28:53 -0500 MIME-Version: 1.0 In-Reply-To: <20121105125731.GA814@polaris.bitmath.org> References: <1351241067-9521-1-git-send-email-benjamin.tissoires@gmail.com> <1351241067-9521-12-git-send-email-benjamin.tissoires@gmail.com> <20121029225748.GA15632@polaris.bitmath.org> <20121105125731.GA814@polaris.bitmath.org> Date: Mon, 5 Nov 2012 14:28:52 +0100 Message-ID: Subject: Re: [PATCH v2 11/11] HID: hid-multitouch: get rid of usbhid depedency for general path From: Benjamin Tissoires To: Henrik Rydberg Cc: Dmitry Torokhov , Jiri Kosina , Stephane Chatty , linux-input , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1495 Lines: 38 Hi Henrik, On Mon, Nov 5, 2012 at 1:57 PM, Henrik Rydberg wrote: > Hi Benjamin, > >> >> This patch factorizes the hid set_feature command by using >> >> hid_device->hid_output_raw_report instead of direclty relying on >> >> usbhid. This makes the driver usb independant. >> >> >> >> However I still can't remove the 2 usb related headers because the >> >> function mt_resume has a specific patch for usb devices. >> >> >> >> Signed-off-by: Benjamin Tissoires >> >> --- >> >> drivers/hid/hid-multitouch.c | 63 ++++++++++++++++++++++++++------------------ >> >> 1 file changed, 37 insertions(+), 26 deletions(-) >> > >> > In my drawer, I have a patchset that aims to remove all usbhid >> > dependence, from all the drivers. Perhaps the attached patch is >> > something to consider here? >> >> yep, removing usbhid dependencies is a good thing. >> See my review below :) > > I have a tentative patch taking your comments into account, and it is > likely that we want to go that way. However, as to not hold up your > patchset, perhaps we could do without it for now. > > Regarding the hardwired usbhid dependency, I think the solution is to > move that code to usbhid itself. > > Thanks, > Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/