Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933136Ab2KEPdn (ORCPT ); Mon, 5 Nov 2012 10:33:43 -0500 Received: from cantor2.suse.de ([195.135.220.15]:59980 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932892Ab2KEPdk (ORCPT ); Mon, 5 Nov 2012 10:33:40 -0500 Date: Mon, 5 Nov 2012 16:33:35 +0100 (CET) From: Jiri Kosina To: Herton Ronaldo Krzesinski Cc: Fengguang Wu , Vivek Goyal , Ben Hutchings , Jens Axboe , LKML Subject: Re: [floppy, blk_peek_request] BUG: scheduling while atomic: kworker/u:0/6/0x10000002 In-Reply-To: <20121105152706.GA3200@herton-Z68MA-D2H-B3> Message-ID: References: <20121105070106.GA17015@localhost> <20121105152706.GA3200@herton-Z68MA-D2H-B3> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2030 Lines: 72 On Mon, 5 Nov 2012, Herton Ronaldo Krzesinski wrote: > > Fengguang, does the patch below make any difference for you please? > > > > Thanks. > > Yes, I saw the same thing here, destroy_workqueue should be done before > clearing the queue (blk_cleanup_queue) indeed. user_reset_fdc called > process_fd_request and that scheduled redo_fd_request, that tries to > take the queue already cleaned up in set_next_request I expect. > > > > > > > > > > > drivers/block/floppy.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c > > index 1c49d71..3b9cc0f 100644 > > --- a/drivers/block/floppy.c > > +++ b/drivers/block/floppy.c > > @@ -4329,6 +4329,7 @@ out_unreg_region: > > platform_driver_unregister(&floppy_driver); > > out_unreg_blkdev: > > unregister_blkdev(FLOPPY_MAJOR, "fd"); > > + destroy_workqueue(floppy_wq); > > This should go right after the out_put_disk label, otherwise we may > leak the floppy_wq on early error. Indeed. Fengguang, could you please test with the patch below instead? (it should be functionally equivalent in most of the cases though). Thanks. drivers/block/floppy.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 1c49d71..e386d83 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -4330,6 +4330,7 @@ out_unreg_region: out_unreg_blkdev: unregister_blkdev(FLOPPY_MAJOR, "fd"); out_put_disk: + destroy_workqueue(floppy_wq); for (drive = 0; drive < N_DRIVE; drive++) { if (!disks[drive]) break; @@ -4340,7 +4341,6 @@ out_put_disk: } put_disk(disks[drive]); } - destroy_workqueue(floppy_wq); return err; } -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/