Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933436Ab2KEWcE (ORCPT ); Mon, 5 Nov 2012 17:32:04 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:36930 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933266Ab2KEWcB (ORCPT ); Mon, 5 Nov 2012 17:32:01 -0500 Date: Mon, 5 Nov 2012 22:31:55 +0000 From: Russell King - ARM Linux To: Mark Langsdorf Cc: "linux-kernel@vger.kernel.org" , "cpufreq@vger.kernel.org" , Rob Herring , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 1/6 v2] arm: use devicetree to get smp_twd clock Message-ID: <20121105223155.GJ28327@n2100.arm.linux.org.uk> References: <1351631056-25938-1-git-send-email-mark.langsdorf@calxeda.com> <1351882309-733-1-git-send-email-mark.langsdorf@calxeda.com> <1351882309-733-2-git-send-email-mark.langsdorf@calxeda.com> <20121104100822.GY21164@n2100.arm.linux.org.uk> <50983D75.50009@calxeda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50983D75.50009@calxeda.com> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 34 On Mon, Nov 05, 2012 at 04:28:05PM -0600, Mark Langsdorf wrote: > On 11/04/2012 04:08 AM, Russell King - ARM Linux wrote: > > On Fri, Nov 02, 2012 at 01:51:44PM -0500, Mark Langsdorf wrote: > >> -static struct clk *twd_get_clock(void) > >> +static struct clk *twd_get_clock(struct device_node *np) > >> { > >> - struct clk *clk; > >> + struct clk *clk = NULL; > >> int err; > >> > >> - clk = clk_get_sys("smp_twd", NULL); > >> + if (np) > >> + clk = of_clk_get(np, 0); > >> + if (!clk) > > > > What does a NULL return from of_clk_get() mean? Where is this defined? > > Well, it's a valid path if (np) is NULL. I'll add an IS_ERR(clk) and > resubmit. Hang on - what logic are you trying to achieve here? Wouldn't: if (np) clk = of_clk_get(np, 0); else clk = clk_get_sys("smp_twd", NULL); be sufficient? If we have DT, why would we ever want to fall back to "smp_twd" ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/