Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933605Ab2KFB5F (ORCPT ); Mon, 5 Nov 2012 20:57:05 -0500 Received: from mail-ob0-f174.google.com ([209.85.214.174]:40195 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933186Ab2KFB5E (ORCPT ); Mon, 5 Nov 2012 20:57:04 -0500 MIME-Version: 1.0 In-Reply-To: References: <1352156701-4038-1-git-send-email-keescook@chromium.org> <1352156701-4038-104-git-send-email-keescook@chromium.org> Date: Mon, 5 Nov 2012 17:57:03 -0800 X-Google-Sender-Auth: j1DE-vMJMzuPGeKSWCmE4Ma2bck Message-ID: Subject: Re: [PATCH 103/104] mm: remove depends on CONFIG_EXPERIMENTAL From: Kees Cook To: David Rientjes Cc: linux-kernel@vger.kernel.org, Andrew Morton , KAMEZAWA Hiroyuki , Jan Beulich , Mel Gorman , Seth Jennings Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 38 On Mon, Nov 5, 2012 at 5:54 PM, Kees Cook wrote: > On Mon, Nov 5, 2012 at 5:22 PM, David Rientjes wrote: >> On Mon, 5 Nov 2012, Kees Cook wrote: >> >>> diff --git a/mm/Kconfig b/mm/Kconfig >>> index a3f8ddd..679945e 100644 >>> --- a/mm/Kconfig >>> +++ b/mm/Kconfig >>> @@ -1,6 +1,5 @@ >>> config SELECT_MEMORY_MODEL >>> def_bool y >>> - depends on EXPERIMENTAL || ARCH_SELECT_MEMORY_MODEL >>> >>> choice >>> prompt "Memory model" >> >> I thought you agreed to only drop EXPERIMENTAL here in >> http://marc.info/?l=linux-kernel&m=135103415901094 and leave >> ARCH_SELECT_MEMORY_MODEL, which you've orphaned with the above, for phase >> two of your effort? > > Ah! Yes, thanks. I'll restore that. Wait, no. This is an "OR". ARCH_SELECT_MEMORY_MODEL has no affect on SELECT_MEMORY_MODEL if EXPERIMENTAL is always considered on. My proposal was to deal with ARCH_SELECT_MEMORY_MODEL separately. Did I misunderstand something? -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/