Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964799Ab2KFCKp (ORCPT ); Mon, 5 Nov 2012 21:10:45 -0500 Received: from ozlabs.org ([203.10.76.45]:41118 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933504Ab2KFCKk (ORCPT ); Mon, 5 Nov 2012 21:10:40 -0500 From: Rusty Russell To: Josh Boyer Cc: Bruno Wolff III , dhowells@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] MODSIGN: Only sign modules if built in-tree In-Reply-To: <20121105191903.GG27352@hansolo.jdub.homelinux.org> References: <20121031132749.GH6627@hansolo.jdub.homelinux.org> <87390t6bs0.fsf@rustcorp.com.au> <20121101112655.GM6627@hansolo.jdub.homelinux.org> <20121101145013.GN6627@hansolo.jdub.homelinux.org> <87liek4rt5.fsf@rustcorp.com.au> <20121102123404.GO6627@hansolo.jdub.homelinux.org> <87vcdkyfi4.fsf@rustcorp.com.au> <20121105191903.GG27352@hansolo.jdub.homelinux.org> User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) Date: Tue, 06 Nov 2012 12:04:02 +1030 Message-ID: <87a9uv5xbp.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1602 Lines: 44 Josh Boyer writes: > On Mon, Nov 05, 2012 at 12:31:39PM +1030, Rusty Russell wrote: >> Josh Boyer writes: >> > diff --git a/Makefile b/Makefile >> > index 14c93b3..7e27d51 100644 >> > --- a/Makefile >> > +++ b/Makefile >> > @@ -722,8 +722,14 @@ export mod_strip_cmd >> > ifeq ($(CONFIG_MODULE_SIG),y) >> > MODSECKEY = ./signing_key.priv >> > MODPUBKEY = ./signing_key.x509 >> > +ifeq ($(KBUILD_EXTMOD),) >> > +SIGNFAIL = false >> > +else >> > +# External builds might not have a signing key, don't break module_install. >> > +SIGNFAIL = true >> > +endif # KBUILD_EXTMOD >> > export MODPUBKEY >> > -mod_sign_cmd = perl $(srctree)/scripts/sign-file $(MODSECKEY) $(MODPUBKEY) >> > +mod_sign_cmd = $(SIGNFAIL) || perl $(srctree)/scripts/sign-file $(MODSECKEY) $(MODPUBKEY) >> > else >> > mod_sign_cmd = true >> > endif >> >> Huh? 'true || perl' never runs perl due to short circuiting. > > Ah. Maybe you were going for "sign all modules if keys are available, > but don't break external if they aren't" semantics. I was just skipping > it entirely for external modules. Exactly. This way you get warnings, not failure. You probably want that, since you'll (at least) taint your kernel when you load those modules. I've applied this in my fixes branch, will push to Linus later this week. Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/