Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090Ab2KFMzI (ORCPT ); Tue, 6 Nov 2012 07:55:08 -0500 Received: from eu1sys200aog116.obsmtp.com ([207.126.144.141]:52069 "EHLO eu1sys200aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454Ab2KFMzG convert rfc822-to-8bit (ORCPT ); Tue, 6 Nov 2012 07:55:06 -0500 From: Loic PALLARDY To: Omar Ramirez Luna Cc: Greg Kroah-Hartman , Russell King , Tony Lindgren , Janusz Krzysztofik , Arnd Bergmann , Ohad Ben-Cohen , Mark Brown , Dom Cobley , Wim Van Sebroeck , Linus Walleij , Suman Anna , Juan Gutierrez , Felipe Contreras , Tejun Heo , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" Date: Tue, 6 Nov 2012 13:53:29 +0100 Subject: Re: [PATCH v2 2/2] mailbox: split internal header from API header Thread-Topic: [PATCH v2 2/2] mailbox: split internal header from API header Thread-Index: Ac28Hbk/LGQ71AyyQgGnoZyf+wqnXA== Message-ID: <50990849.4050003@st.com> References: <1352170552-29564-1-git-send-email-omar.luna@linaro.org> <1352170552-29564-3-git-send-email-omar.luna@linaro.org> In-Reply-To: <1352170552-29564-3-git-send-email-omar.luna@linaro.org> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120412 Thunderbird/11.0.1 acceptlanguage: fr-FR, en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 991 Lines: 27 On 11/06/2012 03:55 AM, Omar Ramirez Luna wrote: > Now internal structures can remain hidden to the user and just API > related functions and defines are made available. > > Signed-off-by: Omar Ramirez Luna > --- > drivers/mailbox/mailbox.c | 34 ++++++++++++++++++++++++++++++++ > drivers/mailbox/mailbox.h | 48 +-------------------------------------------- > include/linux/mailbox.h | 22 +++++++++++++++++++ I agree with the file split but I think mailbox framework API should be more generic. omap_ prefix should not be used. mailbox_ prefix will be better. Message type must be more opened like for example: struct mailbox_msg { int size; unsigned char header; unsigned char *pdata; }; Regards, Loic-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/