Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753206Ab2KFWO0 (ORCPT ); Tue, 6 Nov 2012 17:14:26 -0500 Received: from void.printf.net ([89.145.121.20]:56018 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546Ab2KFWOY (ORCPT ); Tue, 6 Nov 2012 17:14:24 -0500 From: Chris Ball To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Abraham , Will Newton Subject: Re: [PATCH 5/8] mmc: dw_mmc: fix modular build for exynos back-end References: <1352238933-4886-1-git-send-email-arnd@arndb.de> <1352238933-4886-6-git-send-email-arnd@arndb.de> Date: Tue, 06 Nov 2012 17:14:18 -0500 In-Reply-To: <1352238933-4886-6-git-send-email-arnd@arndb.de> (Arnd Bergmann's message of "Tue, 6 Nov 2012 22:55:30 +0100") Message-ID: <87liee8jlx.fsf@octavius.laptop.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1631 Lines: 47 Hi Arnd, On Tue, Nov 06 2012, Arnd Bergmann wrote: > The MODULE_DEVICE_TABLE entry for dw_mci_exynos_match > was incorrectly copied from the platform back-end, which > causes this error when building the driver as a loadable > module: > > drivers/mmc/host/dw_mmc-exynos.c: At top level: > drivers/mmc/host/dw_mmc-exynos.c:226:34: error: '__mod_of_device_table' aliased to undefined symbol 'dw_mci_pltfm_match' > > This patch fixes the problem by just using the correct > string. > > Signed-off-by: Arnd Bergmann > Cc: Thomas Abraham > Cc: Will Newton > Cc: Chris Ball > --- > drivers/mmc/host/dw_mmc-exynos.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c > index 660bbc5..0147ac3a 100644 > --- a/drivers/mmc/host/dw_mmc-exynos.c > +++ b/drivers/mmc/host/dw_mmc-exynos.c > @@ -223,7 +223,7 @@ static const struct of_device_id dw_mci_exynos_match[] = { > .data = (void *)&exynos5250_drv_data, }, > {}, > }; > -MODULE_DEVICE_TABLE(of, dw_mci_pltfm_match); > +MODULE_DEVICE_TABLE(of, dw_mci_exynos_match); > > int dw_mci_exynos_probe(struct platform_device *pdev) > { Thanks, pushed to mmc-next for 3.7. - Chris. -- Chris Ball One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/