Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753144Ab2KFWUL (ORCPT ); Tue, 6 Nov 2012 17:20:11 -0500 Received: from [93.179.225.50] ([93.179.225.50]:39191 "EHLO shrek.podlesie.net" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751609Ab2KFWUK (ORCPT ); Tue, 6 Nov 2012 17:20:10 -0500 From: Krzysztof Mazur To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Chas Williams - CONTRACTOR , David Woodhouse , davem@davemloft.net Subject: [PATCH v3 0/7] pppoatm: fix multiple issues with pppoatm driver Date: Tue, 6 Nov 2012 23:16:55 +0100 Message-Id: <1352240222-363-1-git-send-email-krzysiek@podlesie.net> X-Mailer: git-send-email 1.8.0.233.g54991f2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1983 Lines: 54 Hi, This patch series fixes multiple issues in the pppoatm driver. Two of them can be easily triggered and appropriate Oops messages were added. Changes in v3: - the original crash after closing vcc is now fixed in ATM layer by "[PATCH v3 1/7] atm: detach protocol before closing vcc", this also fixes the same issue with other ATM protocols, suggested by Chas Williams - add "[PATCH v3 2/7] atm: add owner of push() callback to atmvcc" and "[PATCH v3 4/7] pppoatm: fix module_put() race" to remove assumption of Big Kernel Lock, which is no longer true. The same assumption exists also in other ATM protocols, but it's not fixed by this version. - patch "[PATCH v3 3/7] pppoatm: allow assign only on a connected socket" was added to fix crash, when pppoatm was used on non fully-connected socket. - the order of patches 1 and 2 from v2, now "[PATCH v3 5/7] pppoatm: take ATM socket lock in pppoatm_send()" and "[PATCH v3 6/7] pppoatm: don't send frames on not-ready vcc" was reversed, in "[PATCH v3 5/7] pppoatm: take ATM socket lock in pppoatm_send()" lock operation was moved earlier to protect also pppoatm_may_send(), as suggested by David Woodhouse Both patches were previously Acked by David Woodhouse, but now they are slightly modified and commit message is rewritten, because orignal issue is already fixed in "PATCH v3 1/7". - the "[PATCH v2 3/3] pppoatm: protect against freeing of vcc" was dropped because it's not necessary, this protection is already provided by ATM layer [v2] "[PATCH v2 1/3] pppoatm: don't send frames to destroyed vcc" http://marc.info/?l=linux-kernel&m=135092672625585&w=2 [v1] "[PATCH] pppoatm: don't send frames to destroyed vcc" Krzysztof Mazur -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/