From: "Woodhouse, David" <david.woodhouse@intel.com>
To: Krzysztof Mazur <krzysiek@podlesie.net>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Chas Williams - CONTRACTOR <chas@cmf.nrl.navy.mil>,
        "davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v3 5/7] pppoatm: take ATM socket lock in pppoatm_send()
Thread-Topic: [PATCH v3 5/7] pppoatm: take ATM socket lock in pppoatm_send()
Thread-Index: AQHNvGz3+/ZM1gSqR0mkUiHOeUa5KJfda2IA
Date: Tue, 6 Nov 2012 22:57:39 +0000
Message-ID: <1352242658.7340.19.camel@shinybook.infradead.org>
References: <1352240222-363-1-git-send-email-krzysiek@podlesie.net>
	 <1352240222-363-6-git-send-email-krzysiek@podlesie.net>
In-Reply-To: <1352240222-363-6-git-send-email-krzysiek@podlesie.net>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
Content-ID: <1DDACE81D6B5FA409A8BD38C858EA4BA@intel.com>
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 981
Lines: 24

On Tue, 2012-11-06 at 23:17 +0100, Krzysztof Mazur wrote:
> +       if (sock_owned_by_user(sk_atm(vcc)))
> +               goto nospace;

I still think this one can lead to an infinite stall of the PPP channel,
because we return 0 from pppoatm_send() but never make a later call to
ppp_output_wakeup() to unblock it.

In the existing cases where we could return 0 (because
pppoatm_may_send() said no), we were careful to set the BLOCKED flag and
we *knew* that a packet was in flight so we'd get to wake it up again on
a subsequent pppoatm_pop().

None of that works for this new code path that returns zero.

-- 
                   Sent with MeeGo's ActiveSync support.

David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation


????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?