Date: Wed, 7 Nov 2012 00:30:58 +0100
From: David Sterba <dave@jikos.cz>
To: zwu.kernel@gmail.com
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxram@linux.vnet.ibm.com, viro@zeniv.linux.org.uk,
        david@fromorbit.com, tytso@mit.edu, cmm@us.ibm.com,
        wuzhy@linux.vnet.ibm.com, wenqing.lz@taobao.com
Subject: Re: [RFC v4+ hot_track 12/19] vfs: add one ioctl interface
Message-ID: <20121106233058.GW3102@twin.jikos.cz>
Reply-To: dave@jikos.cz
Mail-Followup-To: zwu.kernel@gmail.com, linux-fsdevel@vger.kernel.org,
	linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-kernel@vger.kernel.org, linuxram@linux.vnet.ibm.com,
	viro@zeniv.linux.org.uk, david@fromorbit.com, tytso@mit.edu,
	cmm@us.ibm.com, wuzhy@linux.vnet.ibm.com, wenqing.lz@taobao.com
References: <1351485061-12297-1-git-send-email-zwu.kernel@gmail.com>
 <1351485061-12297-13-git-send-email-zwu.kernel@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1351485061-12297-13-git-send-email-zwu.kernel@gmail.com>
User-Agent: Mutt/1.5.21 (2011-07-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2452
Lines: 78

On Mon, Oct 29, 2012 at 12:30:54PM +0800, zwu.kernel@gmail.com wrote:
> +static int ioctl_heat_info(struct file *file, void __user *argp)
> +{
> +	struct inode *inode = file->f_dentry->d_inode;
> +	struct hot_heat_info *heat_info;
> +	struct hot_inode_item *he;
> +	int ret = 0;
> +
> +	heat_info = kmalloc(sizeof(struct hot_heat_info),
> +				GFP_KERNEL | GFP_NOFS);

heat_info is small enough to fit onto the stack, so you can avoid the
kmalloc, I don't think there are deep callstacks to be expected.
Nevertheless, if you want to use kmalloc here, then please check the
return value and use GFP_KERNEL.

> +
> +	if (copy_from_user((void *) heat_info,
> +			argp,
> +			sizeof(struct hot_heat_info)) != 0) {
> +		ret = -EFAULT;
> +		goto err;
> +	}
> +
> +	he = hot_inode_item_find(inode->i_sb->s_hot_root, inode->i_ino);
> +	if (!he) {
> +		/* we don't have any info on this file yet */
> +		ret = -ENODATA;
> +		goto err;
> +	}
> +
> +	spin_lock(&he->hot_inode.lock);
> +	heat_info->avg_delta_reads =
> +		(__u64) he->hot_inode.hot_freq_data.avg_delta_reads;
> +	heat_info->avg_delta_writes =
> +		(__u64) he->hot_inode.hot_freq_data.avg_delta_writes;
> +	heat_info->last_read_time =
> +	(__u64) timespec_to_ns(&he->hot_inode.hot_freq_data.last_read_time);
> +	heat_info->last_write_time =
> +	(__u64) timespec_to_ns(&he->hot_inode.hot_freq_data.last_write_time);
> +	heat_info->num_reads =
> +		(__u32) he->hot_inode.hot_freq_data.nr_reads;
> +	heat_info->num_writes =
> +		(__u32) he->hot_inode.hot_freq_data.nr_writes;
> +
> +	if (heat_info->live > 0) {
> +		/*
> +		 * got a request for live temperature,
> +		 * call hot_hash_calc_temperature to recalculate
> +		 */
> +		heat_info->temp =
> +		inode->i_sb->s_hot_root->hot_func_type->ops.hot_temp_calc_fn(
> +					&he->hot_inode.hot_freq_data);
> +	} else {
> +		/* not live temperature, get it from the hashlist */
> +		heat_info->temp = he->hot_inode.hot_freq_data.last_temp;
> +	}
> +	spin_unlock(&he->hot_inode.lock);
> +
> +	hot_inode_item_put(he);
> +
> +	if (copy_to_user(argp, (void *) heat_info,
> +			sizeof(struct hot_heat_info))) {
> +		ret = -EFAULT;
> +		goto err;
> +	}
> +
> +err:
> +	kfree(heat_info);
> +	return ret;
> +}

david
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/