Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753984Ab2KGAaI (ORCPT ); Tue, 6 Nov 2012 19:30:08 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:53837 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753612Ab2KGAaG (ORCPT ); Tue, 6 Nov 2012 19:30:06 -0500 Subject: Re: [PATCH 077/104] drivers/target/sbp: remove depends on CONFIG_EXPERIMENTAL From: "Nicholas A. Bellinger" To: Kees Cook Cc: linux-kernel@vger.kernel.org, Chris Boot , target-devel In-Reply-To: <1352156701-4038-78-git-send-email-keescook@chromium.org> References: <1352156701-4038-1-git-send-email-keescook@chromium.org> <1352156701-4038-78-git-send-email-keescook@chromium.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 06 Nov 2012 16:30:03 -0800 Message-ID: <1352248203.29589.234.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1463 Lines: 38 On Mon, 2012-11-05 at 15:04 -0800, Kees Cook wrote: > The CONFIG_EXPERIMENTAL config item has not carried much meaning for a > while now and is almost always enabled by default. As agreed during the > Linux kernel summit, remove it from any "depends on" lines in Kconfigs. > > CC: Chris Boot > CC: "Nicholas A. Bellinger" > Signed-off-by: Kees Cook > --- > drivers/target/sbp/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/target/sbp/Kconfig b/drivers/target/sbp/Kconfig > index 132da54..1614bc7 100644 > --- a/drivers/target/sbp/Kconfig > +++ b/drivers/target/sbp/Kconfig > @@ -1,6 +1,6 @@ > config SBP_TARGET > tristate "FireWire SBP-2 fabric module" > - depends on FIREWIRE && EXPERIMENTAL > + depends on FIREWIRE > help > Say Y or M here to enable SCSI target functionality over FireWire. > This enables you to expose SCSI devices to other nodes on the FireWire Looks fine to drop this usage for sbp-target. Do you want this patch to be include into the target-pending/for-next -> for-3.8 branch, or are you planning to take this full series upstream through a different tree..? --nab -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/