Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751143Ab2KGFLx (ORCPT ); Wed, 7 Nov 2012 00:11:53 -0500 Received: from mail-vc0-f174.google.com ([209.85.220.174]:57330 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761Ab2KGFLw (ORCPT ); Wed, 7 Nov 2012 00:11:52 -0500 MIME-Version: 1.0 In-Reply-To: <1352215003-30268-1-git-send-email-linus.walleij@stericsson.com> References: <1352215003-30268-1-git-send-email-linus.walleij@stericsson.com> Date: Wed, 7 Nov 2012 10:41:51 +0530 X-Google-Sender-Auth: hnbhqgcctKpkmDZvcx3aFXYmiNA Message-ID: Subject: Re: [PATCH 2/5] gpiolib-of: staticize the pin range calls From: viresh kumar To: Linus Walleij Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Shiraz Hashim , Stephen Warren , Anmar Oueja , Grant Likely , Linus Walleij Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 35 On 6 November 2012 20:46, Linus Walleij wrote: diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c #ifdef CONFIG_PINCTRL -void of_gpiochip_add_pin_range(struct gpio_chip *chip) +static void of_gpiochip_add_pin_range(struct gpio_chip *chip) { struct device_node *np = chip->of_node; struct gpio_pin_range *pin_range; @@ -254,7 +254,7 @@ void of_gpiochip_add_pin_range(struct gpio_chip *chip) } while (index++); } -void of_gpiochip_remove_pin_range(struct gpio_chip *chip) +static void of_gpiochip_remove_pin_range(struct gpio_chip *chip) { struct gpio_pin_range *pin_range, *tmp; @@ -265,8 +265,8 @@ void of_gpiochip_remove_pin_range(struct gpio_chip *chip) } } #else -void of_gpiochip_add_pin_range(struct gpio_chip *chip) {} -void of_gpiochip_remove_pin_range(struct gpio_chip *chip) {} +static void of_gpiochip_add_pin_range(struct gpio_chip *chip) {} +static void of_gpiochip_remove_pin_range(struct gpio_chip *chip) {} Maybe static inline?? Reviewed-by: Viresh Kumar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/